Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: ash/wm/overview/window_grid.h

Issue 358553004: Added text filtering to Overview Mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/overview/window_grid.h
diff --git a/ash/wm/overview/window_grid.h b/ash/wm/overview/window_grid.h
index fe4bf780ccc21a98c4ef46edd122fd684f5a437c..1a1a111a79007ca542bbe57bc193b5421ac86cf2 100644
--- a/ash/wm/overview/window_grid.h
+++ b/ash/wm/overview/window_grid.h
@@ -66,6 +66,10 @@ class ASH_EXPORT WindowGrid : public aura::WindowObserver {
// this grid owns.
bool Contains(const aura::Window* window) const;
+ // Dims the items that do not match the given pattern and prevents their
+ // selection.
+ void Filter(const base::string16& pattern);
tdanderson 2014/06/25 15:48:23 I'd prefer a slightly more descriptive name such a
Nina 2014/06/26 15:20:17 Done.
+
// Returns true if the grid has no more windows.
bool empty() const { return window_list_.empty(); }
@@ -124,6 +128,9 @@ class ASH_EXPORT WindowGrid : public aura::WindowObserver {
// Current selected window position.
size_t selected_index_;
+ // Indicates if there is at least one non filtered item in the overview.
tdanderson 2014/06/25 15:48:23 I notice that you are using four different terms i
Nina 2014/06/26 15:20:17 The echoes of my English teacher - don't repeat th
+ bool item_active_;
tdanderson 2014/06/25 15:48:23 I would re-name to be more descriptive, e.g., some
Nina 2014/06/26 15:20:17 Done.
+
// Number of columns in the grid.
size_t num_columns_;

Powered by Google App Engine
This is Rietveld 408576698