Added text filtering to Overview Mode

ash/wm/overview/window_grid.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_OVERVIEW_WINDOW_GRID_H_
 #define ASH_WM_OVERVIEW_WINDOW_GRID_H_
 
 #include <vector>
 
 #include "ash/wm/overview/window_selector.h"
@@ skipping 48 matching lines @@
   // this window grid bounds.
   bool Move(WindowSelector::Direction direction);
 
   // Returns the target selected window, or NULL if there is none selected.
   WindowSelectorItem* SelectedWindow() const;
 
   // Returns true if a window is contained in any of the WindowSelectorItems
   // this grid owns.
   bool Contains(const aura::Window* window) const;
 
+  // Dims the items that do not match the given pattern and prevents their
+  // selection.
+  void Filter(const base::string16& pattern);

[tdanderson, 2014/06/25 15:48:23]

I'd prefer a slightly more descriptive name such as "FilterItems"

[Nina, 2014/06/26 15:20:17]

Done.

+
   // Returns true if the grid has no more windows.
   bool empty() const { return window_list_.empty(); }
 
   // Returns how many window selector items are in the grid.
   size_t size() const { return window_list_.size(); }
 
   // Returns true if the selection widget is active.
   bool is_selecting() const { return selection_widget_ != NULL; }
 
   // Returns the root window in which the grid displays the windows.
@@ skipping 38 matching lines @@
 
   // Vector containing the observed windows.
   std::set<aura::Window*> observed_windows_;
 
   // Widget that indicates to the user which is the selected window.
   scoped_ptr<views::Widget> selection_widget_;
 
   // Current selected window position.
   size_t selected_index_;
 
+  // Indicates if there is at least one non filtered item in the overview.

[tdanderson, 2014/06/25 15:48:23]

I notice that you are using four different terms in your comments, method names,
and variable names to all mean essentially the same thing: dimmed, filtered,
active, and visible. I suggest using the same one everywhere for consistency.
"Visible" is a bit misleading since the items are still visible (just
transparent), and "active" is overloaded. So I'd go with either "dimmed" or
"filtered".

[Nina, 2014/06/26 15:20:17]

The echoes of my English teacher - don't repeat the same word, use synonyms!
Actually dimmed and filtered mean one thing, active and visible another thing.
Changed.

+  bool item_active_;

[tdanderson, 2014/06/25 15:48:23]

I would re-name to be more descriptive, e.g., something like has_active_item_.
The name as-is suggests that there is only one "item" and it is either active or
not.

[Nina, 2014/06/26 15:20:17]

Done.

+
   // Number of columns in the grid.
   size_t num_columns_;
 
   DISALLOW_COPY_AND_ASSIGN(WindowGrid);
 };
 
 }  // namespace ash
 
 #endif  // ASH_WM_OVERVIEW_WINDOW_GRID_H_