Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 358213002: device_status_check shouldn't expect dumpsys iphonesubinfo to provide output. (Closed)

Created:
6 years, 5 months ago by navabi
Modified:
6 years, 5 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

device_status_check shouldn't expect dumpsys iphonesubinfo to provide output. BUG=389470 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280586

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/pylib/android_commands.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
navabi
6 years, 5 months ago (2014-06-28 00:37:37 UTC) #1
Primiano Tucci (use gerrit)
LGTM, thanks!
6 years, 5 months ago (2014-06-30 06:58:58 UTC) #2
mkosiba (inactive)
lgtm
6 years, 5 months ago (2014-06-30 07:56:32 UTC) #3
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 5 months ago (2014-06-30 08:19:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/358213002/1
6 years, 5 months ago (2014-06-30 08:20:17 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-06-30 11:31:06 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-30 11:35:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/21627)
6 years, 5 months ago (2014-06-30 11:35:34 UTC) #8
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 5 months ago (2014-06-30 11:54:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/358213002/1
6 years, 5 months ago (2014-06-30 11:55:54 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 11:57:02 UTC) #11
Message was sent while issue was closed.
Change committed as 280586

Powered by Google App Engine
This is Rietveld 408576698