build/android/pylib/android_commands.py - Issue 358213002: device_status_check shouldn't expect dumpsys iphonesubinfo to provide output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/android_commands.py

Issue 358213002: device_status_check shouldn't expect dumpsys iphonesubinfo to provide output. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/android_commands.py

diff --git a/build/android/pylib/android_commands.py b/build/android/pylib/android_commands.py

index 32121432480103f0e071d4488825ebb6b2fc9011..d231558f38d49e3fd65b9246853c2683050aa2a7 100644

--- a/build/android/pylib/android_commands.py

+++ b/build/android/pylib/android_commands.py

@@ -1351,7 +1351,7 @@ class AndroidCommands(object):

def GetSubscriberInfo(self):

"""Returns the device subscriber info (e.g. GSM and device ID) as string."""

iphone_sub = self.RunShellCommand('dumpsys iphonesubinfo')

- assert iphone_sub

+ # Do not assert here. Devices (e.g. Nakasi on K) may not have iphonesubinfo.

return '\n'.join(iphone_sub)

def GetBatteryInfo(self):

« no previous file with comments | « no previous file | no next file » | no next file with comments »