Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 358163002: Prevent a use after free in computeBlockPreferredLogicalWidths (Closed)

Created:
6 years, 5 months ago by pdr.
Modified:
6 years, 5 months ago
Reviewers:
skobes
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, rune+blink
Project:
blink
Visibility:
Public.

Description

Prevent a use after free in computeBlockPreferredLogicalWidths This patch fixes a use after free during preferred logical width calculation when we have autosizing enabled. This is a speculative local fix to see if more of these regressions pop up; the final fix will need to address crbug.com/389648 as well. BUG=385268 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177152

Patch Set 1 #

Patch Set 2 : Add expectation #

Patch Set 3 : Add pass expectation sice this now passes on release asan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/text-autosizing/table-inflation-crash.html View 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/fast/text-autosizing/table-inflation-crash-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
pdr.
6 years, 5 months ago (2014-06-27 19:11:22 UTC) #1
skobes
lgtm As discussed via chat, please verify this fix on the asan trybot before committing.
6 years, 5 months ago (2014-06-27 19:16:35 UTC) #2
pdr.
On 2014/06/27 19:16:35, skobes wrote: > lgtm > > As discussed via chat, please verify ...
6 years, 5 months ago (2014-06-27 20:09:02 UTC) #3
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 5 months ago (2014-06-27 20:09:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/358163002/40001
6 years, 5 months ago (2014-06-27 20:09:51 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-06-27 21:13:52 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 22:20:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/13997)
6 years, 5 months ago (2014-06-27 22:20:58 UTC) #8
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 5 months ago (2014-06-27 22:22:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/358163002/40001
6 years, 5 months ago (2014-06-27 22:22:52 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 23:23:40 UTC) #11
Message was sent while issue was closed.
Change committed as 177152

Powered by Google App Engine
This is Rietveld 408576698