Source/core/rendering/RenderBlock.cpp - Issue 358163002: Prevent a use after free in computeBlockPreferredLogicalWidths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlock.cpp

Issue 358163002: Prevent a use after free in computeBlockPreferredLogicalWidths (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add pass expectation sice this now passes on release asan Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderBlock.cpp

diff --git a/Source/core/rendering/RenderBlock.cpp b/Source/core/rendering/RenderBlock.cpp

index f4458ec08119a511a26487d532eabce3de231adb..8317a0ff4e6498ef56618dbe81a48bc5c259c88b 100644

--- a/Source/core/rendering/RenderBlock.cpp

+++ b/Source/core/rendering/RenderBlock.cpp

@@ -3660,7 +3660,7 @@ void RenderBlock::computeBlockPreferredLogicalWidths(LayoutUnit& minLogicalWidth

continue;

}

- RenderStyle* childStyle = child->style();

+ RefPtr<RenderStyle> childStyle = child->style();

if (child->isFloating() || (child->isBox() && toRenderBox(child)->avoidsFloats())) {

LayoutUnit floatTotalWidth = floatLeftWidth + floatRightWidth;

if (childStyle->clear() & CLEFT) {

« no previous file with comments | « LayoutTests/fast/text-autosizing/table-inflation-crash-expected.txt ('k') | no next file » | no next file with comments »