Source/core/rendering/compositing/RenderLayerCompositor.h - Issue 358153003: Get rid of one-off paint invalidation code for paints-into-ancestor compositing state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/RenderLayerCompositor.h

Issue 358153003: Get rid of one-off paint invalidation code for paints-into-ancestor compositing state (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/rendering/compositing/GraphicsLayerUpdater.cpp ('k') | Source/core/rendering/compositing/RenderLayerCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/compositing/RenderLayerCompositor.h

diff --git a/Source/core/rendering/compositing/RenderLayerCompositor.h b/Source/core/rendering/compositing/RenderLayerCompositor.h

index 377a07d72739b99d2a0e200b51f9d9e2da5fee2e..7f28d98caa3775af3f7e367da56dde9e2240ac26 100644

--- a/Source/core/rendering/compositing/RenderLayerCompositor.h

+++ b/Source/core/rendering/compositing/RenderLayerCompositor.h

@@ -117,7 +117,6 @@ public:

// Repaint the appropriate layers when the given RenderLayer starts or stops being composited.

void repaintOnCompositingChange(RenderLayer*);

- void repaintInCompositedAncestor(RenderLayer*, const LayoutRect&);

void repaintCompositedLayers();

RenderLayer* rootRenderLayer() const;

@@ -188,6 +187,8 @@ private:

void assertNoUnresolvedDirtyBits();

#endif

+ void repaintInCompositedAncestor(RenderLayer*, const LayoutRect&);

Ian Vollick 2014/06/27 20:42:56 Should this not be gone entirely?

chrishtr 2014/06/27 20:48:21 Yes, thanks for catching that. Fixed.

// Make updates to the layer based on viewport-constrained properties such as position:fixed. This can in turn affect

// compositing.

bool updateLayerIfViewportConstrained(RenderLayer*);