Get rid of one-off paint invalidation code for paints-into-ancestor compositing state

Source/core/rendering/compositing/RenderLayerCompositor.h

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 99 matching lines @@
     bool needsContentsCompositingLayer(const RenderLayer*) const;
 
     bool supportsFixedRootBackgroundCompositing() const;
     bool needsFixedRootBackgroundLayer(const RenderLayer*) const;
     GraphicsLayer* fixedRootBackgroundLayer() const;
     void setNeedsUpdateFixedBackground() { m_needsUpdateFixedBackground = true; }
 
     // Repaint the appropriate layers when the given RenderLayer starts or stops being composited.
     void repaintOnCompositingChange(RenderLayer*);
 
-    void repaintInCompositedAncestor(RenderLayer*, const LayoutRect&);
     void repaintCompositedLayers();
 
     RenderLayer* rootRenderLayer() const;
     GraphicsLayer* rootGraphicsLayer() const;
     GraphicsLayer* scrollLayer() const;
     GraphicsLayer* containerLayer() const;
 
     // We don't always have a root transform layer. This function lazily allocates one
     // and returns it as required.
     GraphicsLayer* ensureRootTransformLayer();
@@ skipping 50 matching lines @@
 
     bool inOverlayFullscreenVideo() const { return m_inOverlayFullscreenVideo; }
 
 private:
     class OverlapMap;
 
 #if ASSERT_ENABLED
     void assertNoUnresolvedDirtyBits();
 #endif
 
+    void repaintInCompositedAncestor(RenderLayer*, const LayoutRect&);

[Ian Vollick, 2014/06/27 20:42:56]

Should this not be gone entirely?

[chrishtr, 2014/06/27 20:48:21]

Yes, thanks for catching that. Fixed.

+
     // Make updates to the layer based on viewport-constrained properties such as position:fixed. This can in turn affect
     // compositing.
     bool updateLayerIfViewportConstrained(RenderLayer*);
 
     // GraphicsLayerClient implementation
     virtual void notifyAnimationStarted(const GraphicsLayer*, double) OVERRIDE { }
     virtual void paintContents(const GraphicsLayer*, GraphicsContext&, GraphicsLayerPaintingPhase, const IntRect&) OVERRIDE;
 
     virtual bool isTrackingRepaints() const OVERRIDE;
 
@@ skipping 68 matching lines @@
 #if USE(RUBBER_BANDING)
     OwnPtr<GraphicsLayer> m_layerForOverhangShadow;
 #endif
 
     bool m_inOverlayFullscreenVideo;
 };
 
 } // namespace WebCore
 
 #endif // RenderLayerCompositor_h