Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 358153003: Get rid of one-off paint invalidation code for paints-into-ancestor compositing state (Closed)

Created:
6 years, 5 months ago by chrishtr
Modified:
6 years, 5 months ago
CC:
abarth-chromium, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Get rid of one-off paint invalidation code for paints-into-ancestor compositing state. Instead use the same paths as other compositing updates. BUG=384520 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177157

Patch Set 1 #

Patch Set 2 : Fixes. #

Patch Set 3 : Fixed. #

Total comments: 2

Patch Set 4 : Addressed comment from vollick@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -31 lines) Patch
M LayoutTests/compositing/squashing/squash-above-fixed-1-expected.txt View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 2 chunks +6 lines, -12 lines 0 comments Download
M Source/core/rendering/compositing/GraphicsLayerUpdater.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 2 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
chrishtr
6 years, 5 months ago (2014-06-27 20:39:45 UTC) #1
Ian Vollick
lgtm https://codereview.chromium.org/358153003/diff/40001/Source/core/rendering/compositing/RenderLayerCompositor.h File Source/core/rendering/compositing/RenderLayerCompositor.h (right): https://codereview.chromium.org/358153003/diff/40001/Source/core/rendering/compositing/RenderLayerCompositor.h#newcode190 Source/core/rendering/compositing/RenderLayerCompositor.h:190: void repaintInCompositedAncestor(RenderLayer*, const LayoutRect&); Should this not be ...
6 years, 5 months ago (2014-06-27 20:42:56 UTC) #2
chrishtr
https://codereview.chromium.org/358153003/diff/40001/Source/core/rendering/compositing/RenderLayerCompositor.h File Source/core/rendering/compositing/RenderLayerCompositor.h (right): https://codereview.chromium.org/358153003/diff/40001/Source/core/rendering/compositing/RenderLayerCompositor.h#newcode190 Source/core/rendering/compositing/RenderLayerCompositor.h:190: void repaintInCompositedAncestor(RenderLayer*, const LayoutRect&); On 2014/06/27 20:42:56, Ian Vollick ...
6 years, 5 months ago (2014-06-27 20:48:21 UTC) #3
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 5 months ago (2014-06-27 20:48:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/358153003/60001
6 years, 5 months ago (2014-06-27 20:48:55 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-06-28 00:06:46 UTC) #6
Message was sent while issue was closed.
Change committed as 177157

Powered by Google App Engine
This is Rietveld 408576698