Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 357663002: [Nit] Removing traces of lazy-block implementation from BisonCSSParser-in.cpp (Closed)

Created:
6 years, 6 months ago by patro
Modified:
6 years, 4 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[Nit] Removing traces of lazy-block implementation from BisonCSSParser-in.cpp It was added as a part of this patch https://codereview.chromium.org/13937017 It was reverted here https://chromiumcodereview.appspot.com/23072015 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179047

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
patro
Please Review
6 years, 6 months ago (2014-06-25 10:46:30 UTC) #1
patro
The CQ bit was checked by behara.ms@samsung.com
6 years, 6 months ago (2014-06-25 10:49:23 UTC) #2
patro
The CQ bit was unchecked by behara.ms@samsung.com
6 years, 6 months ago (2014-06-25 10:49:24 UTC) #3
esprehn
lgtm
6 years, 6 months ago (2014-06-26 04:33:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/behara.ms@samsung.com/357663002/1
6 years, 6 months ago (2014-06-26 04:33:22 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-26 04:33:29 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/css/parser/BisonCSSParser-in.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-26 04:33:29 UTC) #7
patro
The CQ bit was checked by behara.ms@samsung.com
6 years, 4 months ago (2014-07-28 15:07:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/behara.ms@samsung.com/357663002/20001
6 years, 4 months ago (2014-07-28 15:08:07 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-28 16:12:38 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 16:45:25 UTC) #11
Message was sent while issue was closed.
Change committed as 179047

Powered by Google App Engine
This is Rietveld 408576698