Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 13937017: Implement lazy block layout prototype behind a runtime flag. (Closed)

Created:
7 years, 8 months ago by leviw_travelin_and_unemployed
Modified:
7 years, 8 months ago
Reviewers:
jamesr, eseidel, esprehn, ojan
CC:
blink-reviews, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, jamesr
Visibility:
Public.

Description

Implement lazy block layout prototype behind a runtime flag. This patch adds a new display type "lazy-block" that does a highly constrained block layout that allows us to avoid laying out content outside the viewport until we need it, and speeds up insertion/ removal of children both in and out of the viewport. This is still in a prototype phase, and is being landed behind a runtime flag that will default to off. BUG=235595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149140

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -1 line) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSParser.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/StyleResolver.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/FrameView.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/FrameView.cpp View 4 chunks +34 lines, -0 lines 1 comment Download
M Source/core/rendering/RenderLayer.cpp View 2 chunks +3 lines, -0 lines 3 comments Download
A Source/core/rendering/RenderLazyBlock.h View 1 chunk +95 lines, -0 lines 0 comments Download
A Source/core/rendering/RenderLazyBlock.cpp View 1 chunk +254 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderView.h View 3 chunks +6 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 3 chunks +8 lines, -0 lines 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
esprehn
LGTM.
7 years, 8 months ago (2013-04-25 23:30:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/13937017/1
7 years, 8 months ago (2013-04-25 23:31:27 UTC) #2
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=5564
7 years, 8 months ago (2013-04-25 23:49:38 UTC) #3
leviw_travelin_and_unemployed
Committed patchset #1 manually as r149140 (presubmit successful).
7 years, 8 months ago (2013-04-26 00:00:16 UTC) #4
ojan
https://codereview.chromium.org/13937017/diff/1/Source/core/rendering/RenderLayer.cpp File Source/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/13937017/diff/1/Source/core/rendering/RenderLayer.cpp#newcode2345 Source/core/rendering/RenderLayer.cpp:2345: view->markLazyBlocksForLayout(); Doesn't not doing the layout here mean that ...
7 years, 8 months ago (2013-04-26 00:41:15 UTC) #5
esprehn
https://codereview.chromium.org/13937017/diff/1/Source/core/rendering/RenderLayer.cpp File Source/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/13937017/diff/1/Source/core/rendering/RenderLayer.cpp#newcode2345 Source/core/rendering/RenderLayer.cpp:2345: view->markLazyBlocksForLayout(); On 2013/04/26 00:41:16, ojan wrote: > Doesn't not ...
7 years, 8 months ago (2013-04-26 00:45:44 UTC) #6
jamesr
https://codereview.chromium.org/13937017/diff/1/Source/core/rendering/RenderLayer.cpp File Source/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/13937017/diff/1/Source/core/rendering/RenderLayer.cpp#newcode2345 Source/core/rendering/RenderLayer.cpp:2345: view->markLazyBlocksForLayout(); On 2013/04/26 00:45:44, esprehn wrote: > On 2013/04/26 ...
7 years, 8 months ago (2013-04-26 00:58:03 UTC) #7
eseidel
7 years, 8 months ago (2013-04-27 09:09:34 UTC) #8
Message was sent while issue was closed.
I really hope I don't regret doing this on trunk. :)  I wish we had a real
git.chromium.org to use for awesome experiments like this.

https://codereview.chromium.org/13937017/diff/1/Source/core/page/FrameView.cpp
File Source/core/page/FrameView.cpp (right):

https://codereview.chromium.org/13937017/diff/1/Source/core/page/FrameView.cp...
Source/core/page/FrameView.cpp:1181: if (!renderView()->firstLazyBlock())
Is this expensive?

Powered by Google App Engine
This is Rietveld 408576698