Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 357573004: Land Recent QUIC Changes. (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)
Modified:
6 years, 5 months ago
Reviewers:
wtc, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, wtc, jar (doing other things), alyssar, Ian Swett, dmz
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes. Removing deprecated flag FLAGS_enable_quic_stream_flow_control_2 Per-stream flow control is deemed safe at this point (the bug is open due to connection level flow control) so we can kill it off as a part of removing Qv17. removing deprecated flag FLAGS_enable_quic_stream_flow_control_2 Merge internal change: 69784569 https://codereview.chromium.org/346303006/ Added ProcessPacketInterface interface and QuicDispatcher is derived from it. This change is the merge of "QUIC backend group code for UDP proxy session" CL. Merge internal change: 69778759 https://codereview.chromium.org/352253002/ Changes congestion-options used in the config to a more general connection-options. Merge internal change: 69773863 https://codereview.chromium.org/353903003/ Documented HandshakeFailureReason's enum values with one-sentence comments. Minor change to keep the code similar to chromium. Merge internal change: 69773346 https://codereview.chromium.org/359483002/ Allow QUIC pacing and time-based loss detection to be enabled via congestion options. Merge internal change: 69683639 https://codereview.chromium.org/354523004/ R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280166

Patch Set 1 #

Patch Set 2 : Rebase with TOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -193 lines) Patch
M net/quic/crypto/quic_crypto_server_config.h View 1 chunk +21 lines, -7 lines 0 comments Download
M net/quic/quic_config.h View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_config.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M net/quic/quic_config_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_crypto_stream_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_data_stream_test.cc View 7 chunks +0 lines, -7 lines 0 comments Download
M net/quic/quic_dispatcher.h View 1 4 chunks +11 lines, -12 lines 0 comments Download
M net/quic/quic_dispatcher.cc View 1 3 chunks +3 lines, -24 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M net/quic/quic_flow_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/quic_flow_controller_test.cc View 3 chunks +1 line, -4 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M net/quic/quic_session_test.cc View 10 chunks +0 lines, -10 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M net/quic/test_tools/quic_config_peer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_config_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/tools/quic/quic_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 4 chunks +11 lines, -12 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 3 chunks +4 lines, -26 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M net/tools/quic/quic_server.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
ramant (doing other things)
6 years, 6 months ago (2014-06-26 03:23:29 UTC) #1
ramant (doing other things)
Hi Ryan, Wanted to merge all crypto related changes (and other changes that come after ...
6 years, 6 months ago (2014-06-26 03:25:27 UTC) #2
Ryan Hamilton
lgtm Your plan of doing the other changes in a different CL makes sense.
6 years, 6 months ago (2014-06-26 15:47:11 UTC) #3
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 6 months ago (2014-06-26 17:26:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/357573004/1
6 years, 6 months ago (2014-06-26 17:27:41 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-26 17:44:36 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-26 17:48:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/165315) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/154586) mac_gpu ...
6 years, 6 months ago (2014-06-26 17:48:19 UTC) #8
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 6 months ago (2014-06-26 18:12:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/357573004/40001
6 years, 6 months ago (2014-06-26 18:17:15 UTC) #10
commit-bot: I haz the power
Change committed as 280166
6 years, 6 months ago (2014-06-26 23:40:35 UTC) #11
wtc
6 years, 5 months ago (2014-06-30 23:33:35 UTC) #12
Message was sent while issue was closed.
Patch set 2 LGTM.

Powered by Google App Engine
This is Rietveld 408576698