Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Unified Diff: net/tools/quic/quic_dispatcher_test.cc

Issue 357573004: Land Recent QUIC Changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase with TOT Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_dispatcher.cc ('k') | net/tools/quic/quic_server.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_dispatcher_test.cc
diff --git a/net/tools/quic/quic_dispatcher_test.cc b/net/tools/quic/quic_dispatcher_test.cc
index 41c3c27946aed4e2738d4251f379cabcbbe77acf..691e7f8f31c9177a05cadd34ca3e8d902c079697 100644
--- a/net/tools/quic/quic_dispatcher_test.cc
+++ b/net/tools/quic/quic_dispatcher_test.cc
@@ -260,48 +260,6 @@ TEST_F(QuicDispatcherTest, StrayPacketToTimeWaitListManager) {
ProcessPacket(client_address, connection_id, false, "foo");
}
-TEST(QuicDispatcherFlowControlTest, NoNewVersion17ConnectionsIfFlagDisabled) {
- // If FLAGS_enable_quic_stream_flow_control_2 is disabled
- // then the dispatcher should stop creating connections that support
- // QUIC_VERSION_17 (existing connections will stay alive).
- // TODO(rjshade): Remove once
- // FLAGS_enable_quic_stream_flow_control_2 is removed.
-
- EpollServer eps;
- QuicConfig config;
- QuicCryptoServerConfig server_config(QuicCryptoServerConfig::TESTING,
- QuicRandom::GetInstance());
- IPEndPoint client(net::test::Loopback4(), 1);
- IPEndPoint server(net::test::Loopback4(), 1);
- QuicConnectionId kCID = 1234;
-
- QuicVersion kTestQuicVersions[] = {QUIC_VERSION_17,
- QUIC_VERSION_16,
- QUIC_VERSION_15};
- QuicVersionVector kTestVersions;
- for (size_t i = 0; i < arraysize(kTestQuicVersions); ++i) {
- kTestVersions.push_back(kTestQuicVersions[i]);
- }
-
- QuicDispatcher dispatcher(config, server_config, kTestVersions, &eps);
- dispatcher.Initialize(0);
-
- // When flag is enabled, new connections should support QUIC_VERSION_17.
- ValueRestore<bool> old_flag(&FLAGS_enable_quic_stream_flow_control_2, true);
- scoped_ptr<QuicConnection> connection_1(
- QuicDispatcherPeer::CreateQuicConnection(&dispatcher, kCID, client,
- server));
- EXPECT_EQ(QUIC_VERSION_17, connection_1->version());
-
-
- // When flag is disabled, new connections should not support QUIC_VERSION_17.
- FLAGS_enable_quic_stream_flow_control_2 = false;
- scoped_ptr<QuicConnection> connection_2(
- QuicDispatcherPeer::CreateQuicConnection(&dispatcher, kCID, client,
- server));
- EXPECT_EQ(QUIC_VERSION_16, connection_2->version());
-}
-
class BlockingWriter : public QuicPacketWriterWrapper {
public:
BlockingWriter() : write_blocked_(false) {}
« no previous file with comments | « net/tools/quic/quic_dispatcher.cc ('k') | net/tools/quic/quic_server.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698