Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: content/browser/media/media_source_browsertest.cc

Issue 357413002: Have media content and chrome browser tests load data from media/test/data (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: few merge fixes Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/media_source_browsertest.cc
diff --git a/content/browser/media/media_source_browsertest.cc b/content/browser/media/media_source_browsertest.cc
index d5d86154637056c7242f684dbd2087d8372ac66d..7a6bcc963fd57d84cab101ed619107b94c888182 100644
--- a/content/browser/media/media_source_browsertest.cc
+++ b/content/browser/media/media_source_browsertest.cc
@@ -40,8 +40,8 @@ class MediaSourceTest : public content::MediaBrowserTest {
}
std::vector<StringPair> query_params;
- query_params.push_back(std::make_pair("mediafile", media_file));
- query_params.push_back(std::make_pair("mediatype", media_type));
+ query_params.push_back(std::make_pair("mediaFile", media_file));
jrummell 2014/07/02 00:33:40 Should these tags (mediaFile, mediaType, keySystem
shadi 2014/07/02 19:23:36 It seems like an over kill. These params are tied
+ query_params.push_back(std::make_pair("mediaType", media_type));
jrummell 2014/07/02 00:33:40 The other place where parameters are created has u
shadi 2014/07/02 19:23:36 True, but this test only uses media_source_player.
RunMediaTestPage("media_source_player.html", &query_params, expectation,
true);
}

Powered by Google App Engine
This is Rietveld 408576698