Have media content and chrome browser tests load data from media/test/data

content/browser/media/media_source_browsertest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "content/browser/media/media_browsertest.h"
 #include "content/public/common/content_switches.h"
 #if defined(OS_ANDROID)
 #include "base/android/build_info.h"
 #endif
@@ skipping 22 matching lines @@
 class MediaSourceTest : public content::MediaBrowserTest {
  public:
   void TestSimplePlayback(const char* media_file, const char* media_type,
                           const char* expectation) {
     if (!IsMSESupported()) {
       VLOG(0) << "Skipping test - MSE not supported.";
       return;
     }
 
     std::vector<StringPair> query_params;
-    query_params.push_back(std::make_pair("mediafile", media_file));
-    query_params.push_back(std::make_pair("mediatype", media_type));
+    query_params.push_back(std::make_pair("mediaFile", media_file));

[jrummell, 2014/07/02 00:33:40]

Should these tags (mediaFile, mediaType, keySystem, useMSE, etc.) be defined in
one place like test_utils?

[shadi, 2014/07/02 19:23:36]

It seems like an over kill. These params are tied to whatever HTML and JS code
uses, so either side can break things....

+    query_params.push_back(std::make_pair("mediaType", media_type));

[jrummell, 2014/07/02 00:33:40]

The other place where parameters are created has useMSE flag. Since this
requires MSE (at least from the comment above), should we not specify it as a
parameter instead of relying on a default?

[shadi, 2014/07/02 19:23:36]

True, but this test only uses media_source_player.html which explicitly loads
video by MSE commands.

     RunMediaTestPage("media_source_player.html", &query_params, expectation,
                      true);
   }
 
 #if defined(OS_ANDROID)
   virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
     command_line->AppendSwitch(
         switches::kDisableGestureRequirementForMediaPlayback);
   }
 #endif
@@ skipping 26 matching lines @@
 // Test changed to skip checks resulting in flakiness. Proper fix still needed.
 IN_PROC_BROWSER_TEST_F(MediaSourceTest, ConfigChangeVideo) {
   if (!IsMSESupported()) {
     VLOG(0) << "Skipping test - MSE not supported.";
     return;
   }
   RunMediaTestPage("mse_config_change.html", NULL, kEnded, true);
 }
 
 }  // namespace content