Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 357303002: Remove getMediaDevices interface. (Closed)

Created:
6 years, 5 months ago by Henrik Grunell
Modified:
6 years, 5 months ago
CC:
blink-reviews, tommyw+watchlist_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove getMediaDevices interface. getMediaDevices was landed for M37 but the spec changed just at the M37 cut without a heads-up. So we are removing getMediaDevices and replacing it with MediaDevices.enumerateDevices for M38. This CL depends on reverting/disabling test code: https://codereview.chromium.org/341123005/ BUG=388648 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177480

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -86 lines) Patch
D LayoutTests/fast/mediastream/getMediaDevices.html View 1 chunk +0 lines, -51 lines 0 comments Download
D LayoutTests/fast/mediastream/getMediaDevices-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
M Source/modules/mediastream/NavigatorMediaStream.idl View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Henrik Grunell
6 years, 5 months ago (2014-06-30 11:55:16 UTC) #1
tommi (sloooow) - chröme
Generally it's easy to understand what a change does, but 'why' is often harder to ...
6 years, 5 months ago (2014-06-30 12:09:21 UTC) #2
Henrik Grunell
On 2014/06/30 12:09:21, tommi wrote: > Generally it's easy to understand what a change does, ...
6 years, 5 months ago (2014-06-30 12:15:15 UTC) #3
tommi (sloooow) - chröme
lgtm
6 years, 5 months ago (2014-06-30 12:30:02 UTC) #4
jochen (gone - plz use gerrit)
So we're keeping the getMediaDevices API around for m37 or will you merge this back?
6 years, 5 months ago (2014-07-01 10:03:20 UTC) #5
tommi (sloooow) - chröme
On 2014/07/01 10:03:20, jochen wrote: > So we're keeping the getMediaDevices API around for m37 ...
6 years, 5 months ago (2014-07-01 10:06:37 UTC) #6
jochen (gone - plz use gerrit)
On 2014/07/01 at 10:06:37, tommi wrote: > On 2014/07/01 10:03:20, jochen wrote: > > So ...
6 years, 5 months ago (2014-07-01 10:08:04 UTC) #7
Henrik Grunell
The CQ bit was checked by grunell@chromium.org
6 years, 5 months ago (2014-07-03 13:49:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/357303002/20001
6 years, 5 months ago (2014-07-03 13:50:57 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 14:53:44 UTC) #10
Message was sent while issue was closed.
Change committed as 177480

Powered by Google App Engine
This is Rietveld 408576698