Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 356953009: Revert of Consolidate attachment URL construction. (Closed)

Created:
6 years, 6 months ago by leng
Modified:
6 years, 6 months ago
Reviewers:
maniscalco, pavely
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Consolidate attachment URL construction. (https://codereview.chromium.org/355093002/) Reason for revert: Broke compile on ChromiumOS on Linux: ../../chrome/browser/sync/profile_sync_components_factory_impl.cc: In member function 'virtual scoped_ptr<syncer::AttachmentService> ProfileSyncComponentsFactoryImpl::CreateAttachmentService(syncer::AttachmentService::Delegate*)': ../../chrome/browser/sync/profile_sync_components_factory_impl.cc:648:44: error: 'url_prefix' was not declared in this scope ninja: build stopped: subcommand failed. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/6230/steps/compile/logs/stdio Original issue's description: > Consolidate attachment URL construction. > > Fix bug where attachment URLs could end up with too many slashes. > > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280193 TBR=pavely@chromium.org,maniscalco@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280196

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -81 lines) Patch
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 4 chunks +9 lines, -1 line 0 comments Download
M sync/api/attachments/attachment_downloader.h View 2 chunks +3 lines, -2 lines 0 comments Download
M sync/api/attachments/attachment_downloader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/attachments/attachment_downloader_impl.cc View 5 chunks +9 lines, -5 lines 0 comments Download
M sync/internal_api/attachments/attachment_downloader_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/attachments/attachment_uploader_impl.cc View 4 chunks +7 lines, -17 lines 0 comments Download
M sync/internal_api/attachments/attachment_uploader_impl_unittest.cc View 7 chunks +6 lines, -42 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_downloader_impl.h View 5 chunks +5 lines, -4 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_uploader_impl.h View 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
leng
Created Revert of Consolidate attachment URL construction.
6 years, 6 months ago (2014-06-27 01:36:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/356953009/1
6 years, 6 months ago (2014-06-27 01:37:09 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-27 01:38:59 UTC) #3
Message was sent while issue was closed.
Change committed as 280196

Powered by Google App Engine
This is Rietveld 408576698