Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: sync/internal_api/public/attachments/attachment_uploader_impl.h

Issue 356953009: Revert of Consolidate attachment URL construction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sync/internal_api/public/attachments/attachment_downloader_impl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_UPLOADER_IMPL_H_ 5 #ifndef SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_UPLOADER_IMPL_H_
6 #define SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_UPLOADER_IMPL_H_ 6 #define SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_UPLOADER_IMPL_H_
7 7
8 #include "base/containers/scoped_ptr_hash_map.h" 8 #include "base/containers/scoped_ptr_hash_map.h"
9 #include "base/threading/non_thread_safe.h" 9 #include "base/threading/non_thread_safe.h"
10 #include "google_apis/gaia/oauth2_token_service_request.h" 10 #include "google_apis/gaia/oauth2_token_service_request.h"
11 #include "net/url_request/url_request_context_getter.h" 11 #include "net/url_request/url_request_context_getter.h"
12 #include "sync/api/attachments/attachment_uploader.h" 12 #include "sync/api/attachments/attachment_uploader.h"
13 13
14 class GURL; 14 class GURL;
15 15
16 namespace net { 16 namespace net {
17 class URLRequestContextGetter; 17 class URLRequestContextGetter;
18 } // namespace net 18 } // namespace net
19 19
20 namespace syncer { 20 namespace syncer {
21 21
22 // An implementation of AttachmentUploader. 22 // An implementation of AttachmentUploader.
23 class SYNC_EXPORT AttachmentUploaderImpl : public AttachmentUploader, 23 class SYNC_EXPORT AttachmentUploaderImpl : public AttachmentUploader,
24 public base::NonThreadSafe { 24 public base::NonThreadSafe {
25 public: 25 public:
26 // |sync_service_url| is the URL of the sync service. 26 // |url_prefix| is the URL prefix (including trailing slash) to be used when
27 // uploading attachments.
27 // 28 //
28 // |url_request_context_getter| provides a URLRequestContext. 29 // |url_request_context_getter| provides a URLRequestContext.
29 // 30 //
30 // |account_id| is the account id to use for uploads. 31 // |account_id| is the account id to use for uploads.
31 // 32 //
32 // |scopes| is the set of scopes to use for uploads. 33 // |scopes| is the set of scopes to use for uploads.
33 // 34 //
34 // |token_service_provider| provides an OAuth2 token service. 35 // |token_service_provider| provides an OAuth2 token service.
35 AttachmentUploaderImpl( 36 AttachmentUploaderImpl(
36 const GURL& sync_service_url, 37 const std::string& url_prefix,
37 const scoped_refptr<net::URLRequestContextGetter>& 38 const scoped_refptr<net::URLRequestContextGetter>&
38 url_request_context_getter, 39 url_request_context_getter,
39 const std::string& account_id, 40 const std::string& account_id,
40 const OAuth2TokenService::ScopeSet& scopes, 41 const OAuth2TokenService::ScopeSet& scopes,
41 scoped_ptr<OAuth2TokenServiceRequest::TokenServiceProvider> 42 scoped_ptr<OAuth2TokenServiceRequest::TokenServiceProvider>
42 token_service_provider); 43 token_service_provider);
43 virtual ~AttachmentUploaderImpl(); 44 virtual ~AttachmentUploaderImpl();
44 45
45 // AttachmentUploader implementation. 46 // AttachmentUploader implementation.
46 virtual void UploadAttachment(const Attachment& attachment, 47 virtual void UploadAttachment(const Attachment& attachment,
47 const UploadCallback& callback) OVERRIDE; 48 const UploadCallback& callback) OVERRIDE;
48 49
49 // Return the URL for the given |sync_service_url| and |attachment_id|.
50 static GURL GetURLForAttachmentId(const GURL& sync_service_url,
51 const AttachmentId& attachment_id);
52
53 private: 50 private:
54 class UploadState; 51 class UploadState;
55 typedef std::string UniqueId; 52 typedef std::string UniqueId;
56 typedef base::ScopedPtrHashMap<UniqueId, UploadState> StateMap; 53 typedef base::ScopedPtrHashMap<UniqueId, UploadState> StateMap;
57 54
55 GURL GetUploadURLForAttachmentId(const AttachmentId& attachment_id) const;
58 void DeleteUploadStateFor(const UniqueId& unique_id); 56 void DeleteUploadStateFor(const UniqueId& unique_id);
59 57
60 GURL sync_service_url_; 58 std::string url_prefix_;
61 scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_; 59 scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;
62 std::string account_id_; 60 std::string account_id_;
63 OAuth2TokenService::ScopeSet scopes_; 61 OAuth2TokenService::ScopeSet scopes_;
64 scoped_ptr<OAuth2TokenServiceRequest::TokenServiceProvider> 62 scoped_ptr<OAuth2TokenServiceRequest::TokenServiceProvider>
65 token_service_provider_; 63 token_service_provider_;
66 StateMap state_map_; 64 StateMap state_map_;
67 DISALLOW_COPY_AND_ASSIGN(AttachmentUploaderImpl); 65 DISALLOW_COPY_AND_ASSIGN(AttachmentUploaderImpl);
68 }; 66 };
69 67
70 } // namespace syncer 68 } // namespace syncer
71 69
72 #endif // SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_UPLOADER_IMPL_H_ 70 #endif // SYNC_INTERNAL_API_PUBLIC_ATTACHMENTS_ATTACHMENT_UPLOADER_IMPL_H_
OLDNEW
« no previous file with comments | « sync/internal_api/public/attachments/attachment_downloader_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698