Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 356833006: Remove navigator.connection.type from some window tests (Closed)

Created:
6 years, 6 months ago by jkarlin
Modified:
6 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

navigator.connection.type's value can easily change for a given platform over time. Not worth constantly rebaselining. Remove navigator.connection.type from window tests as it's already well tested in netinfo/* tests. BUG=381683 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177119

Patch Set 1 #

Patch Set 2 : Rebase after rebaselined #

Patch Set 3 : Adding NeedsRebaseline #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Messages

Total messages: 8 (0 generated)
jkarlin
fmalita: Thanks for reviewing. This is related to https://codereview.chromium.org/339903003/
6 years, 6 months ago (2014-06-26 12:03:16 UTC) #1
f(malita)
lgtm
6 years, 6 months ago (2014-06-26 12:44:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/356833006/1
6 years, 6 months ago (2014-06-26 12:45:48 UTC) #3
jkarlin
On 2014/06/26 12:44:54, Florin Malita wrote: > lgtm PTAL again. The auto-rebaseliner ran and so ...
6 years, 6 months ago (2014-06-26 18:40:25 UTC) #4
fmalita_google_do_not_use
On 2014/06/26 18:40:25, jkarlin wrote: > On 2014/06/26 12:44:54, Florin Malita wrote: > > lgtm ...
6 years, 6 months ago (2014-06-26 18:42:19 UTC) #5
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 5 months ago (2014-06-27 16:55:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/356833006/60002
6 years, 5 months ago (2014-06-27 16:56:27 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 17:01:58 UTC) #8
Message was sent while issue was closed.
Change committed as 177119

Powered by Google App Engine
This is Rietveld 408576698