LayoutTests/fast/dom/Window/resources/window-property-collector.js - Issue 356833006: Remove navigator.connection.type from some window tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/Window/resources/window-property-collector.js

Issue 356833006: Remove navigator.connection.type from some window tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt ('k') | LayoutTests/platform/linux/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/Window/resources/window-property-collector.js

diff --git a/LayoutTests/fast/dom/Window/resources/window-property-collector.js b/LayoutTests/fast/dom/Window/resources/window-property-collector.js

index ae730480f6954f1db8c234d91c71e3ec3df22fcf..7067772fa8badc36a8689e29bdd03555bdf34ed0 100644

--- a/LayoutTests/fast/dom/Window/resources/window-property-collector.js

+++ b/LayoutTests/fast/dom/Window/resources/window-property-collector.js

@@ -43,6 +43,11 @@ function emitExpectedResult(path, expected)

// Various special cases for legacy reasons. Please do not add entries to this list.

var propertyPath = path.join('.');

+ // Connection type depends on the host, skip.

+ if (propertyPath == 'navigator.connection.type')

+ return;

switch (propertyPath) {

case "location.href":

expected = "'about:blank'";

@@ -65,7 +70,6 @@ function emitExpectedResult(path, expected)

case "navigator.product":

case "navigator.productSub":

case "navigator.vendor":

- case "navigator.connection.type":

expected = "window." + propertyPath;

break;

case "screen.orientation":