Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 356783003: Account for scroll when positioning the flakiness dashboard popup (Closed)

Created:
6 years, 5 months ago by pdr.
Modified:
6 years, 5 months ago
Reviewers:
ojan
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Account for scroll when positioning the flakiness dashboard popup This patch updates the popup on the flakiness dashboard to be under the cursor even if the page is scrolled. TEST=manual, verified the popup works when scrolled in both Chrome and Firefox. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177173

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Tools/TestResultServer/static-dashboards/ui.js View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
pdr.
6 years, 5 months ago (2014-06-28 21:20:17 UTC) #1
ojan
lgtm. Thx for fixing. I won't make you write tests for this since you're not ...
6 years, 5 months ago (2014-06-29 03:46:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/356783003/1
6 years, 5 months ago (2014-06-29 03:47:16 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-06-29 04:51:14 UTC) #4
Message was sent while issue was closed.
Change committed as 177173

Powered by Google App Engine
This is Rietveld 408576698