Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2323)

Unified Diff: Tools/TestResultServer/static-dashboards/ui.js

Issue 356783003: Account for scroll when positioning the flakiness dashboard popup (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/TestResultServer/static-dashboards/ui.js
diff --git a/Tools/TestResultServer/static-dashboards/ui.js b/Tools/TestResultServer/static-dashboards/ui.js
index ea9b468c1027dc83e7eb44ac32808b3f99e64afe..3e9160a330120c9de324734300478965981aa895 100644
--- a/Tools/TestResultServer/static-dashboards/ui.js
+++ b/Tools/TestResultServer/static-dashboards/ui.js
@@ -58,13 +58,13 @@ ui.popup.show = function(target, html)
var x = Math.min(targetRect.left - 10, document.documentElement.clientWidth - popup.offsetWidth);
x = Math.max(0, x);
- popup.style.left = x + document.body.scrollLeft + 'px';
+ popup.style.left = x + window.pageXOffset + 'px';
ojan 2014/06/29 03:46:37 This part of the web platform is so crufty. :(
var y = targetRect.top + targetRect.height;
if (y + popup.offsetHeight > document.documentElement.clientHeight)
y = targetRect.top - popup.offsetHeight;
y = Math.max(0, y);
- popup.style.top = y + document.body.scrollTop + 'px';
+ popup.style.top = y + window.pageYOffset + 'px';
}
ui.popup._handleMouseDown = function(e) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698