Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 356713005: Rename ServerBoundCert => ChannelID to reflect the current name (Closed)

Created:
6 years, 5 months ago by Ryan Hamilton
Modified:
6 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, tfarina, jam, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, gavinp+disk_chromium.org
Project:
chromium
Visibility:
Public.

Description

Rename ServerBoundCert => ChannelID to reflect the current name of this feature. TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285432

Patch Set 1 #

Patch Set 2 : s/DomainBoundCert/ChannelID/ #

Patch Set 3 : Rebase #

Total comments: 294

Patch Set 4 : Fix comments. #

Patch Set 5 : Rebase #

Total comments: 2

Patch Set 6 : Upload stashed changes #

Total comments: 32

Patch Set 7 : address comments from jar #

Patch Set 8 : more comments #

Patch Set 9 : Actually rebase #

Patch Set 10 : Rebase again!? #

Patch Set 11 : more fixes #

Patch Set 12 : Fix Android and ChromeOS #

Patch Set 13 : Fix CookiesTreeModelTest #

Patch Set 14 : Rebase #

Patch Set 15 : fix cookies_list.js #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+2792 lines, -6199 lines) Patch
M android_webview/browser/net/aw_url_request_context_getter.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/browser/net/aw_url_request_context_getter.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -6 lines 0 comments Download
A chrome/browser/browsing_data/browsing_data_channel_id_helper.h View 1 2 3 1 chunk +91 lines, -0 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_channel_id_helper.cc View 1 2 3 6 chunks +69 lines, -69 lines 0 comments Download
A chrome/browser/browsing_data/browsing_data_channel_id_helper_unittest.cc View 1 2 3 4 1 chunk +144 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.h View 1 2 3 4 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +29 lines, -26 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 2 3 4 5 6 7 8 4 chunks +49 lines, -48 lines 0 comments Download
D chrome/browser/browsing_data/browsing_data_server_bound_cert_helper.h View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/browser/browsing_data/browsing_data_server_bound_cert_helper.cc View 1 chunk +0 lines, -219 lines 0 comments Download
D chrome/browser/browsing_data/browsing_data_server_bound_cert_helper_unittest.cc View 1 chunk +0 lines, -144 lines 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model.h View 1 2 3 10 chunks +29 lines, -29 lines 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model.cc View 1 2 3 12 chunks +50 lines, -50 lines 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model_unittest.cc View 4 5 6 7 8 9 10 11 12 26 chunks +31 lines, -31 lines 0 comments Download
M chrome/browser/browsing_data/local_data_container.h View 1 2 3 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/browsing_data/local_data_container.cc View 1 2 3 5 chunks +10 lines, -10 lines 0 comments Download
A chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.h View 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.cc View 1 2 3 1 chunk +60 lines, -0 lines 0 comments Download
D chrome/browser/browsing_data/mock_browsing_data_server_bound_cert_helper.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/browsing_data/mock_browsing_data_server_bound_cert_helper.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M chrome/browser/chromeos/login/mock_login_utils.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/profile_auth_data.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/profile_auth_data.cc View 1 2 3 4 5 6 7 8 9 10 11 9 chunks +42 lines, -41 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/local_shared_objects_container.h View 1 2 3 4 5 6 7 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/content_settings/local_shared_objects_container.cc View 1 2 3 4 5 6 7 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.cc View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_property_provider.h View 1 2 3 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_property_provider.cc View 1 5 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_messages_apitest.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/io_thread.h View 1 2 3 4 5 6 7 8 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 2 3 4 5 6 7 8 5 chunks +11 lines, -12 lines 0 comments Download
A + chrome/browser/net/sqlite_channel_id_store.h View 1 2 3 2 chunks +16 lines, -16 lines 0 comments Download
A + chrome/browser/net/sqlite_channel_id_store.cc View 1 2 3 4 20 chunks +83 lines, -81 lines 0 comments Download
A + chrome/browser/net/sqlite_channel_id_store_unittest.cc View 1 2 3 4 11 chunks +91 lines, -91 lines 0 comments Download
D chrome/browser/net/sqlite_server_bound_cert_store.h View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/browser/net/sqlite_server_bound_cert_store.cc View 1 chunk +0 lines, -639 lines 0 comments Download
D chrome/browser/net/sqlite_server_bound_cert_store_unittest.cc View 1 chunk +0 lines, -473 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.h View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 2 3 4 5 6 7 8 7 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 2 3 4 5 6 7 8 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/cookies_list.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +8 lines, -8 lines 1 comment Download
M chrome/browser/ui/views/collected_cookies_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/cookies_tree_model_util.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/cookies_view_handler.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/chrome_constants.h View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/chrome_constants.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M content/browser/browser_context.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/browser/shell_url_request_context_getter.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +6 lines, -6 lines 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +7 lines, -8 lines 0 comments Download
M jingle/glue/proxy_resolving_client_socket.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/glue/xmpp_client_socket_factory.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/cert/x509_util.h View 1 2 3 2 chunks +9 lines, -9 lines 0 comments Download
M net/cert/x509_util.cc View 1 2 3 4 5 6 7 2 chunks +14 lines, -14 lines 0 comments Download
M net/cert/x509_util_nss.cc View 1 2 3 4 chunks +16 lines, -16 lines 0 comments Download
M net/cert/x509_util_nss_unittest.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M net/cert/x509_util_openssl.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M net/cert/x509_util_openssl_unittest.cc View 1 2 3 4 5 6 7 8 3 chunks +12 lines, -12 lines 0 comments Download
M net/http/http_cache.h View 1 2 3 4 5 6 7 8 2 chunks +1 line, -1 line 0 comments Download
M net/http/http_network_session.h View 1 2 3 4 5 6 7 8 3 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_network_session.cc View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M net/net.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +8 lines, -8 lines 0 comments Download
M net/quic/crypto/channel_id_chromium.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/crypto/channel_id_chromium.cc View 1 2 8 chunks +11 lines, -11 lines 0 comments Download
M net/quic/quic_client_session.cc View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_stream_factory.h View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M net/socket/client_socket_pool_manager_impl.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/client_socket_pool_manager_impl.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/socket/socket_test_util.h View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M net/socket/socket_test_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket.h View 1 2 3 5 chunks +10 lines, -10 lines 0 comments Download
M net/socket/ssl_client_socket.cc View 1 2 3 3 chunks +12 lines, -12 lines 0 comments Download
M net/socket/ssl_client_socket_nss.h View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 2 3 4 5 6 7 8 18 chunks +24 lines, -24 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.h View 1 2 3 4 5 6 7 8 4 chunks +6 lines, -6 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 2 3 4 5 6 7 8 6 chunks +8 lines, -8 lines 0 comments Download
M net/socket/ssl_client_socket_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 1 2 3 4 5 6 7 8 3 chunks +47 lines, -46 lines 0 comments Download
M net/socket_stream/socket_stream.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/socket_stream/socket_stream.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 1 comment Download
M net/spdy/spdy_http_stream_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_stream.h View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
A + net/ssl/channel_id_service.h View 1 2 3 4 5 6 7 12 chunks +49 lines, -49 lines 1 comment Download
A + net/ssl/channel_id_service.cc View 1 2 3 4 5 6 7 33 chunks +109 lines, -111 lines 0 comments Download
A + net/ssl/channel_id_service_unittest.cc View 1 2 3 4 5 6 7 26 chunks +183 lines, -183 lines 0 comments Download
A + net/ssl/channel_id_store.h View 1 2 3 4 5 6 chunks +28 lines, -28 lines 0 comments Download
A + net/ssl/channel_id_store.cc View 1 2 3 4 5 2 chunks +8 lines, -8 lines 0 comments Download
A + net/ssl/default_channel_id_store.h View 1 2 3 4 5 8 chunks +48 lines, -48 lines 0 comments Download
A net/ssl/default_channel_id_store.cc View 1 2 3 4 5 1 chunk +471 lines, -0 lines 0 comments Download
A net/ssl/default_channel_id_store_unittest.cc View 1 2 3 4 5 6 7 1 chunk +555 lines, -0 lines 0 comments Download
D net/ssl/default_server_bound_cert_store.h View 1 chunk +0 lines, -192 lines 0 comments Download
D net/ssl/default_server_bound_cert_store.cc View 1 chunk +0 lines, -473 lines 0 comments Download
D net/ssl/default_server_bound_cert_store_unittest.cc View 1 chunk +0 lines, -555 lines 0 comments Download
D net/ssl/server_bound_cert_service.h View 1 chunk +0 lines, -215 lines 0 comments Download
D net/ssl/server_bound_cert_service.cc View 1 chunk +0 lines, -677 lines 0 comments Download
D net/ssl/server_bound_cert_service_unittest.cc View 1 chunk +0 lines, -774 lines 0 comments Download
D net/ssl/server_bound_cert_store.h View 1 chunk +0 lines, -131 lines 0 comments Download
D net/ssl/server_bound_cert_store.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M net/url_request/url_request_context.h View 1 2 3 4 5 6 7 8 4 chunks +7 lines, -7 lines 0 comments Download
M net/url_request/url_request_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 2 3 4 5 6 7 8 3 chunks +7 lines, -7 lines 0 comments Download
M net/url_request/url_request_context_storage.h View 1 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
M net/url_request/url_request_context_storage.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/url_request/url_request_test_util.cc View 1 2 3 4 5 6 7 8 2 chunks +7 lines, -7 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 45 (0 generated)
Ryan Hamilton
Merry Christmas! If this looks good to you, let me know and I'll add OWNERS ...
6 years, 5 months ago (2014-06-30 22:59:46 UTC) #1
wtc
Patch set 3 LGTM. Let's go over some of the comments in person, so I ...
6 years, 5 months ago (2014-07-01 19:50:57 UTC) #2
Ryan Hamilton
I think I've made all the changes you requested. Thanks for the (as always) detailed ...
6 years, 5 months ago (2014-07-21 19:12:14 UTC) #3
Ryan Hamilton
darin: chrome/ OWNERS review. This is a huge CL, but all of the changes are ...
6 years, 5 months ago (2014-07-21 19:15:16 UTC) #4
Ryan Hamilton
jar: tools/metrics/actions/actions.xml OWNERS review. (In particular, I'm not sure if the changes in this file ...
6 years, 5 months ago (2014-07-21 19:16:58 UTC) #5
jar (doing other things)
https://codereview.chromium.org/356713005/diff/80001/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/356713005/diff/80001/tools/metrics/actions/actions.xml#newcode13 tools/metrics/actions/actions.xml:13: If a user action is not being used any ...
6 years, 5 months ago (2014-07-22 22:30:35 UTC) #6
jar (doing other things)
actions.xml LGTM % adding obsolete.
6 years, 5 months ago (2014-07-22 22:36:34 UTC) #7
jar (doing other things)
actions.xml LGTM % adding obsolete.
6 years, 5 months ago (2014-07-22 22:36:40 UTC) #8
Ryan Hamilton
Thanks! https://codereview.chromium.org/356713005/diff/80001/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/356713005/diff/80001/tools/metrics/actions/actions.xml#newcode13 tools/metrics/actions/actions.xml:13: If a user action is not being used ...
6 years, 5 months ago (2014-07-22 22:38:23 UTC) #9
Ryan Hamilton
TBR'ing darin, as per offline conversation and as per the official doc which permits TBRs ...
6 years, 5 months ago (2014-07-22 22:39:33 UTC) #10
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 5 months ago (2014-07-22 22:39:51 UTC) #11
wtc
Patch set 7 LGTM. You can let the commit queue job finish. I'll be happy ...
6 years, 5 months ago (2014-07-22 22:49:33 UTC) #12
Ryan Hamilton
> Could you try "git cl format"? I wonder if that will fix the function ...
6 years, 5 months ago (2014-07-22 23:32:54 UTC) #13
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 5 months ago (2014-07-22 23:33:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/356713005/140001
6 years, 5 months ago (2014-07-22 23:34:39 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 00:48:20 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 00:51:42 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/172730) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/161760) ios_rel_device_ninja ...
6 years, 5 months ago (2014-07-23 00:51:44 UTC) #18
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 5 months ago (2014-07-23 03:09:29 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/356713005/160001
6 years, 5 months ago (2014-07-23 03:10:15 UTC) #20
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 5 months ago (2014-07-23 03:52:46 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/356713005/180001
6 years, 5 months ago (2014-07-23 03:54:11 UTC) #22
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 05:34:31 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 05:41:23 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_dbg/builds/43719) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/52027)
6 years, 5 months ago (2014-07-23 05:41:25 UTC) #25
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 5 months ago (2014-07-23 18:16:13 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/356713005/200001
6 years, 5 months ago (2014-07-23 18:17:56 UTC) #27
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 22:49:00 UTC) #28
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 22:58:52 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/163880) android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/209881)
6 years, 5 months ago (2014-07-23 22:58:54 UTC) #30
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 5 months ago (2014-07-23 23:00:28 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/356713005/220001
6 years, 5 months ago (2014-07-23 23:03:20 UTC) #32
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 5 months ago (2014-07-23 23:31:32 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/356713005/240001
6 years, 5 months ago (2014-07-23 23:33:28 UTC) #34
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 05:36:03 UTC) #35
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 05:38:52 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/52515)
6 years, 5 months ago (2014-07-24 05:38:53 UTC) #37
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 5 months ago (2014-07-24 14:27:32 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/356713005/250001
6 years, 5 months ago (2014-07-24 14:28:47 UTC) #39
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 18:03:06 UTC) #40
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 5 months ago (2014-07-24 18:46:37 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/356713005/270001
6 years, 5 months ago (2014-07-24 18:49:14 UTC) #42
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 23:20:07 UTC) #43
commit-bot: I haz the power
Change committed as 285432
6 years, 5 months ago (2014-07-25 00:26:04 UTC) #44
wtc
6 years, 4 months ago (2014-07-30 04:56:52 UTC) #45
Message was sent while issue was closed. 
Patch set 15 LGTM. I will make the changes I noted below.

https://codereview.chromium.org/356713005/diff/270001/chrome/browser/resource...
File chrome/browser/resources/options/cookies_list.js (right):

https://codereview.chromium.org/356713005/diff/270001/chrome/browser/resource...
chrome/browser/resources/options/cookies_list.js:42: ['created',
'label_channel_id_created']],

Fix the indentation of lines 41-42. (I can take care of this.)

https://codereview.chromium.org/356713005/diff/270001/net/socket_stream/socke...
File net/socket_stream/socket_stream.cc (right):

https://codereview.chromium.org/356713005/diff/270001/net/socket_stream/socke...
net/socket_stream/socket_stream.cc:634: proxy_url_, net::LOAD_NORMAL,
&proxy_info_, io_callback_, &pac_request_,

Note to self: omit "net::".

https://codereview.chromium.org/356713005/diff/270001/net/ssl/channel_id_serv...
File net/ssl/channel_id_service.h (right):

https://codereview.chromium.org/356713005/diff/270001/net/ssl/channel_id_serv...
net/ssl/channel_id_service.h:37: // automatically.

Note to self: update this comment block.

Powered by Google App Engine
This is Rietveld 408576698