Rename ServerBoundCert => ChannelID to reflect the current name

chrome/browser/browsing_data/browsing_data_remover_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/browsing_data_remover.h"
 
 #include <set>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 38 matching lines @@
 #include "components/domain_reliability/service.h"
 #include "content/public/browser/cookie_store_factory.h"
 #include "content/public/browser/dom_storage_context.h"
 #include "content/public/browser/local_storage_usage_info.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/test/test_browser_thread.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "content/public/test/test_utils.h"
 #include "net/cookies/cookie_store.h"
-#include "net/ssl/server_bound_cert_service.h"
-#include "net/ssl/server_bound_cert_store.h"
+#include "net/ssl/channel_id_service.h"
+#include "net/ssl/channel_id_store.h"
 #include "net/ssl/ssl_client_cert_type.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using content::BrowserThread;
 using content::StoragePartition;
 using domain_reliability::CLEAR_BEACONS;
 using domain_reliability::CLEAR_CONTEXTS;
@@ skipping 220 matching lines @@
     browser_process_->SetSafeBrowsingService(NULL);
   }
 
  private:
   TestingBrowserProcess* browser_process_;
 
   DISALLOW_COPY_AND_ASSIGN(RemoveSafeBrowsingCookieTester);
 };
 #endif
 
-class RemoveServerBoundCertTester : public net::SSLConfigService::Observer {
+class RemoveChannelIDTester : public net::SSLConfigService::Observer {
  public:
-  explicit RemoveServerBoundCertTester(TestingProfile* profile)
+  explicit RemoveChannelIDTester(TestingProfile* profile)
       : ssl_config_changed_count_(0) {
-    server_bound_cert_service_ = profile->GetRequestContext()->
-        GetURLRequestContext()->server_bound_cert_service();
+    channel_id_service_ = profile->GetRequestContext()->
+        GetURLRequestContext()->channel_id_service();
     ssl_config_service_ = profile->GetSSLConfigService();
     ssl_config_service_->AddObserver(this);
   }
 
-  virtual ~RemoveServerBoundCertTester() {
+  virtual ~RemoveChannelIDTester() {
     ssl_config_service_->RemoveObserver(this);
   }
 
-  int ServerBoundCertCount() {
-    return server_bound_cert_service_->cert_count();
+  int ChannelIDCount() {
+    return channel_id_service_->cert_count();
   }
 
   // Add a server bound cert for |server| with specific creation and expiry
   // times.  The cert and key data will be filled with dummy values.
-  void AddServerBoundCertWithTimes(const std::string& server_identifier,
+  void AddChannelIDWithTimes(const std::string& server_identifier,
                                    base::Time creation_time,
                                    base::Time expiration_time) {
-    GetCertStore()->SetServerBoundCert(server_identifier,
+    GetCertStore()->SetChannelID(server_identifier,
                                        creation_time,
                                        expiration_time,
                                        "a",
                                        "b");

[wtc, 2014/07/01 19:50:48]

Fix the indentation of this entire method.

[Ryan Hamilton, 2014/07/21 19:12:04]

Done.

   }
 
   // Add a server bound cert for |server|, with the current time as the
   // creation time.  The cert and key data will be filled with dummy values.
-  void AddServerBoundCert(const std::string& server_identifier) {
+  void AddChannelID(const std::string& server_identifier) {
     base::Time now = base::Time::Now();
-    AddServerBoundCertWithTimes(server_identifier,
+    AddChannelIDWithTimes(server_identifier,
                                 now,
                                 now + base::TimeDelta::FromDays(1));
   }
 
-  void GetCertList(net::ServerBoundCertStore::ServerBoundCertList* certs) {
-    GetCertStore()->GetAllServerBoundCerts(
-        base::Bind(&RemoveServerBoundCertTester::GetAllCertsCallback, certs));
+  void GetCertList(net::ChannelIDStore::ChannelIDList* certs) {

[wtc, 2014/07/01 19:50:48]

GetCertList => GetChannelIDList

certs => channel_ids

[Ryan Hamilton, 2014/07/21 19:12:04]

Done.

+    GetCertStore()->GetAllChannelIDs(
+        base::Bind(&RemoveChannelIDTester::GetAllCertsCallback, certs));
   }
 
-  net::ServerBoundCertStore* GetCertStore() {
-    return server_bound_cert_service_->GetCertStore();
+  net::ChannelIDStore* GetCertStore() {

[wtc, 2014/07/01 19:50:48]

GetCertStore => GetChannelIDStore

[Ryan Hamilton, 2014/07/21 19:12:04]

Done.

+    return channel_id_service_->GetCertStore();
   }
 
   int ssl_config_changed_count() const {
     return ssl_config_changed_count_;
   }
 
   // net::SSLConfigService::Observer implementation:
   virtual void OnSSLConfigChanged() OVERRIDE {
     ssl_config_changed_count_++;
   }
 
  private:
   static void GetAllCertsCallback(

[wtc, 2014/07/01 19:50:48]

GetAllCertsCallback => GetAllChannelIDsCallback

[Ryan Hamilton, 2014/07/21 19:12:04]

Done.

-      net::ServerBoundCertStore::ServerBoundCertList* dest,
-      const net::ServerBoundCertStore::ServerBoundCertList& result) {
+      net::ChannelIDStore::ChannelIDList* dest,
+      const net::ChannelIDStore::ChannelIDList& result) {
     *dest = result;
   }
 
-  net::ServerBoundCertService* server_bound_cert_service_;
+  net::ChannelIDService* channel_id_service_;
   scoped_refptr<net::SSLConfigService> ssl_config_service_;
   int ssl_config_changed_count_;
 
-  DISALLOW_COPY_AND_ASSIGN(RemoveServerBoundCertTester);
+  DISALLOW_COPY_AND_ASSIGN(RemoveChannelIDTester);
 };
 
 class RemoveHistoryTester {
  public:
   RemoveHistoryTester() : query_url_success_(false), history_service_(NULL) {}
 
   bool Init(TestingProfile* profile) WARN_UNUSED_RESULT {
     if (!profile->CreateHistoryService(true, false))
       return false;
     history_service_ = HistoryServiceFactory::GetForProfile(
@@ skipping 498 matching lines @@
       BrowsingDataRemover::REMOVE_COOKIES, false);
 
   EXPECT_EQ(BrowsingDataRemover::REMOVE_COOKIES, GetRemovalMask());
   EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginSetMask());
   // Removing with time period other than EVERYTHING should not clear safe
   // browsing cookies.
   EXPECT_TRUE(tester.ContainsCookie());
 }
 #endif
 
-TEST_F(BrowsingDataRemoverTest, RemoveServerBoundCertForever) {
-  RemoveServerBoundCertTester tester(GetProfile());
+TEST_F(BrowsingDataRemoverTest, RemoveChannelIDForever) {
+  RemoveChannelIDTester tester(GetProfile());
 
-  tester.AddServerBoundCert(kTestOrigin1);
+  tester.AddChannelID(kTestOrigin1);
   EXPECT_EQ(0, tester.ssl_config_changed_count());
-  EXPECT_EQ(1, tester.ServerBoundCertCount());
+  EXPECT_EQ(1, tester.ChannelIDCount());
 
   BlockUntilBrowsingDataRemoved(BrowsingDataRemover::EVERYTHING,
-      BrowsingDataRemover::REMOVE_SERVER_BOUND_CERTS, false);
+      BrowsingDataRemover::REMOVE_CHANNEL_IDS, false);
 
-  EXPECT_EQ(BrowsingDataRemover::REMOVE_SERVER_BOUND_CERTS, GetRemovalMask());
+  EXPECT_EQ(BrowsingDataRemover::REMOVE_CHANNEL_IDS, GetRemovalMask());
   EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginSetMask());
   EXPECT_EQ(1, tester.ssl_config_changed_count());
-  EXPECT_EQ(0, tester.ServerBoundCertCount());
+  EXPECT_EQ(0, tester.ChannelIDCount());
 }
 
-TEST_F(BrowsingDataRemoverTest, RemoveServerBoundCertLastHour) {
-  RemoveServerBoundCertTester tester(GetProfile());
+TEST_F(BrowsingDataRemoverTest, RemoveChannelIDLastHour) {
+  RemoveChannelIDTester tester(GetProfile());
 
   base::Time now = base::Time::Now();
-  tester.AddServerBoundCert(kTestOrigin1);
-  tester.AddServerBoundCertWithTimes(kTestOrigin2,
+  tester.AddChannelID(kTestOrigin1);
+  tester.AddChannelIDWithTimes(kTestOrigin2,
                                      now - base::TimeDelta::FromHours(2),
                                      now);
   EXPECT_EQ(0, tester.ssl_config_changed_count());
-  EXPECT_EQ(2, tester.ServerBoundCertCount());
+  EXPECT_EQ(2, tester.ChannelIDCount());
 
   BlockUntilBrowsingDataRemoved(BrowsingDataRemover::LAST_HOUR,
-      BrowsingDataRemover::REMOVE_SERVER_BOUND_CERTS, false);
+      BrowsingDataRemover::REMOVE_CHANNEL_IDS, false);
 
-  EXPECT_EQ(BrowsingDataRemover::REMOVE_SERVER_BOUND_CERTS, GetRemovalMask());
+  EXPECT_EQ(BrowsingDataRemover::REMOVE_CHANNEL_IDS, GetRemovalMask());
   EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginSetMask());
   EXPECT_EQ(1, tester.ssl_config_changed_count());
-  ASSERT_EQ(1, tester.ServerBoundCertCount());
-  net::ServerBoundCertStore::ServerBoundCertList certs;
+  ASSERT_EQ(1, tester.ChannelIDCount());
+  net::ChannelIDStore::ChannelIDList certs;
   tester.GetCertList(&certs);
   ASSERT_EQ(1U, certs.size());
   EXPECT_EQ(kTestOrigin2, certs.front().server_identifier());
 }
 
 TEST_F(BrowsingDataRemoverTest, RemoveUnprotectedLocalStorageForever) {
   // Protect kOrigin1.
   scoped_refptr<MockExtensionSpecialStoragePolicy> mock_policy =
       new MockExtensionSpecialStoragePolicy;
   mock_policy->AddProtected(kOrigin1.GetOrigin());
@@ skipping 847 matching lines @@
   EXPECT_EQ(1u, tester.clear_count());
   EXPECT_EQ(CLEAR_CONTEXTS, tester.last_clear_mode());
 }
 
 TEST_F(BrowsingDataRemoverTest, DomainReliability_NoMonitor) {
   BlockUntilBrowsingDataRemoved(
       BrowsingDataRemover::EVERYTHING,
       BrowsingDataRemover::REMOVE_HISTORY |
       BrowsingDataRemover::REMOVE_COOKIES, false);
 }