Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 356623004: Removing the unused function didNavigate (Closed)

Created:
6 years, 6 months ago by suyash
Modified:
6 years, 6 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, jamesr, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

The function is now replaced by continueProgram(),hence there is no need of it. The original TODO required changes on both chromium and blink side. Since both patches have landed we can safely remove the unused function. Link to blink patch : https://codereview.chromium.org/330603003/ Link to chromium patch : https://codereview.chromium.org/330663002/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M Source/web/WebDevToolsAgentImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebDevToolsAgent.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
suyash
PTAL :)
6 years, 6 months ago (2014-06-25 09:00:51 UTC) #1
yurys
lgtm
6 years, 6 months ago (2014-06-25 11:22:17 UTC) #2
suyash
Thanks yurys :)
6 years, 6 months ago (2014-06-25 12:58:59 UTC) #3
suyash
@pfeldman PTAL :)
6 years, 6 months ago (2014-06-25 15:51:16 UTC) #4
pfeldman
lgtm
6 years, 6 months ago (2014-06-25 15:51:50 UTC) #5
suyash
thanks @pfeldman! :)
6 years, 6 months ago (2014-06-25 17:58:21 UTC) #6
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 6 months ago (2014-06-25 17:58:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/356623004/1
6 years, 6 months ago (2014-06-25 17:58:49 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 18:59:29 UTC) #9
Message was sent while issue was closed.
Change committed as 176942

Powered by Google App Engine
This is Rietveld 408576698