Promotion is the backup strategy when semi-space copy fails and vice versa.

Promotion is the backup strategy when semi-space copy fails and vice versa.

BUG=
R=ishell@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22002

[Igor Sheludko, 2014-06-25 09:06:37]

lgtm

https://codereview.chromium.org/356613004/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/356613004/diff/1/src/heap.cc#newcode1991
src/heap.cc:1991: // In that case we allocate in the old generation.
Probably this comment should not be here since you already added similar comment
in if (!heap->ShouldBePromoted()) below.

[Hannes Payer (out of office), 2014-06-25 09:25:44]

https://codereview.chromium.org/356613004/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/356613004/diff/1/src/heap.cc#newcode1991
src/heap.cc:1991: // In that case we allocate in the old generation.
On 2014/06/25 09:06:37, Igor Sheludko wrote:
> Probably this comment should not be here since you already added similar
comment
> in if (!heap->ShouldBePromoted()) below.

Done.

[Hannes Payer (out of office), 2014-06-25 09:31:36]

Committed patchset #2 manually as r22002 (presubmit successful).