src/heap-inl.h - Issue 356613004: Promotion is the backup strategy when semi-space copy fails and vice versa.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-inl.h

Issue 356613004: Promotion is the backup strategy when semi-space copy fails and vice versa. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap-inl.h

diff --git a/src/heap-inl.h b/src/heap-inl.h

index 22e4c971a9b9af983398c2f2df0118de97df25c3..162dac2237efbe86e8450ddc99a7bb5129f4c564 100644

--- a/src/heap-inl.h

+++ b/src/heap-inl.h

@@ -388,8 +388,6 @@ bool Heap::OldGenerationAllocationLimitReached() {

bool Heap::ShouldBePromoted(Address old_address, int object_size) {

- // An object should be promoted if the object has survived a

- // scavenge operation.

NewSpacePage* page = NewSpacePage::FromAddress(old_address);

Address age_mark = new_space_.age_mark();

return page->IsFlagSet(MemoryChunk::NEW_SPACE_BELOW_AGE_MARK) &&

« no previous file with comments | « src/heap.cc ('k') | no next file » | no next file with comments »