chrome/browser/geolocation/geolocation_permission_context.cc - Issue 356543003: Audit the last usage of Geolocation and Notification permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_permission_context.cc

Issue 356543003: Audit the last usage of Geolocation and Notification permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/host_content_settings_map.h ('K') | « chrome/browser/content_settings/host_content_settings_map.cc ('k') | chrome/browser/notifications/desktop_notification_service.cc » ('j') | chrome/browser/notifications/desktop_notification_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_permission_context.cc

diff --git a/chrome/browser/geolocation/geolocation_permission_context.cc b/chrome/browser/geolocation/geolocation_permission_context.cc

index ca97bfad53c30733a0bc396e44f5df521a127247..481b5d4b2a9fae76a6af8e03672b0d883780da41 100644

--- a/chrome/browser/geolocation/geolocation_permission_context.cc

+++ b/chrome/browser/geolocation/geolocation_permission_context.cc

@@ -205,6 +205,8 @@ void GeolocationPermissionContext::DecidePermission(

PermissionDecided(id, requesting_frame, embedder, callback, false);

break;

case CONTENT_SETTING_ALLOW:

+ profile_->GetHostContentSettingsMap()->UpdateLastUsage(

Michael van Ouwerkerk 2014/06/26 10:26:39 Why is this only called for this one case? If you

Daniel Nishi 2014/06/26 20:31:25 NotifyPermissionSet doesn't have a reference to |e

+ requesting_frame, embedder, CONTENT_SETTINGS_TYPE_GEOLOCATION);

PermissionDecided(id, requesting_frame, embedder, callback, true);

break;

default: