Audit the last usage of Geolocation and Notification permissions.

chrome/browser/geolocation/geolocation_permission_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/geolocation/geolocation_permission_context.h"
 
 #include <functional>
 #include <string>
 #include <vector>
 
@@ skipping 187 matching lines @@
 
   ContentSetting content_setting =
      profile_->GetHostContentSettingsMap()->GetContentSetting(
           requesting_frame, embedder, CONTENT_SETTINGS_TYPE_GEOLOCATION,
           std::string());
   switch (content_setting) {
     case CONTENT_SETTING_BLOCK:
       PermissionDecided(id, requesting_frame, embedder, callback, false);
       break;
     case CONTENT_SETTING_ALLOW:
+      profile_->GetHostContentSettingsMap()->UpdateLastUsage(

[Michael van Ouwerkerk, 2014/06/26 10:26:39]

Why is this only called for this one case? If you wanted to instrument all cases
from a single place, NotifyPermissionSet seems suitable.

[Daniel Nishi, 2014/06/26 20:31:25]

NotifyPermissionSet doesn't have a reference to |embedder| which is used as the
secondary pattern.

This handles the case that there is no interactivity on allowing the permission.
It could also be in PermissionDecided, but this avoids an if-statement on
|allowed|.

The interactive case is handled by the update also occurring in the
HostContentSettingsMap's |SetContentSetting|.

+          requesting_frame, embedder, CONTENT_SETTINGS_TYPE_GEOLOCATION);
       PermissionDecided(id, requesting_frame, embedder, callback, true);
       break;
     default:
       if (PermissionBubbleManager::Enabled()) {
         PermissionBubbleManager* mgr =
             PermissionBubbleManager::FromWebContents(web_contents);
         if (mgr) {
           scoped_ptr<GeolocationPermissionRequest> request_ptr(
               new GeolocationPermissionRequest(
                   this, id, requesting_frame, user_gesture, callback,
@@ skipping 102 matching lines @@
     if (cancelling != NULL && web_contents != NULL &&
         PermissionBubbleManager::FromWebContents(web_contents) != NULL) {
       PermissionBubbleManager::FromWebContents(web_contents)->
           CancelRequest(cancelling);
     }
     return;
   }
 
   QueueController()->CancelInfoBarRequest(id);
 }