Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: content/browser/geolocation/geolocation_dispatcher_host.cc

Issue 356543003: Audit the last usage of Geolocation and Notification permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add auditing for actual usage, too. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/geolocation/geolocation_dispatcher_host.cc
diff --git a/content/browser/geolocation/geolocation_dispatcher_host.cc b/content/browser/geolocation/geolocation_dispatcher_host.cc
index ad1f2fcc4441f138726f67d6f0e8e049302e5962..b89368f31d2e13db6f6a2fc642b7ce1a9a57e623 100644
--- a/content/browser/geolocation/geolocation_dispatcher_host.cc
+++ b/content/browser/geolocation/geolocation_dispatcher_host.cc
@@ -21,6 +21,8 @@
namespace content {
namespace {
+const char kGeolocationPermission[] = "geolocation";
+
// Geoposition error codes for reporting in UMA.
enum GeopositionErrorCode {
// NOTE: Do not renumber these as that would confuse interpretation of
@@ -186,6 +188,12 @@ void GeolocationDispatcherHost::OnStartUpdating(
"Geolocation.GeolocationDispatcherHostImpl.EnableHighAccuracy",
enable_high_accuracy);
+ GetContentClient()->browser()->UseContentSettingPermission(
Michael van Ouwerkerk 2014/07/01 11:02:23 If this is meant to track actual successful usage
Daniel Nishi 2014/07/01 18:37:48 I've moved the call into OnLocationUpdate in the f
+ web_contents(),
+ requesting_frame,
+ web_contents()->GetLastCommittedURL().GetOrigin(),
+ kGeolocationPermission);
+
updating_frames_[render_frame_host] = enable_high_accuracy;
RefreshGeolocationOptions();
}

Powered by Google App Engine
This is Rietveld 408576698