Audit the last usage of Geolocation and Notification permissions.

content/browser/geolocation/geolocation_dispatcher_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/geolocation/geolocation_dispatcher_host.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/metrics/histogram.h"
 #include "content/browser/frame_host/render_frame_host_impl.h"
 #include "content/browser/renderer_host/render_message_filter.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/common/geoposition.h"
 #include "content/common/geolocation_messages.h"
 
 namespace content {
 namespace {
 
+const char kGeolocationPermission[] = "geolocation";
+
 // Geoposition error codes for reporting in UMA.
 enum GeopositionErrorCode {
   // NOTE: Do not renumber these as that would confuse interpretation of
   // previously logged data. When making changes, also update the enum list
   // in tools/metrics/histograms/histograms.xml to keep it in sync.
 
   // There was no error.
   GEOPOSITION_ERROR_CODE_NONE = 0,
 
   // User denied use of geolocation.
@@ skipping 145 matching lines @@
 void GeolocationDispatcherHost::OnStartUpdating(
     RenderFrameHost* render_frame_host,
     const GURL& requesting_frame,
     bool enable_high_accuracy) {
   // StartUpdating() can be invoked as a result of high-accuracy mode
   // being enabled / disabled. No need to record the dispatcher again.
   UMA_HISTOGRAM_BOOLEAN(
       "Geolocation.GeolocationDispatcherHostImpl.EnableHighAccuracy",
       enable_high_accuracy);
 
+  GetContentClient()->browser()->UseContentSettingPermission(

[Michael van Ouwerkerk, 2014/07/01 11:02:23]

If this is meant to track actual successful usage of the Geolocation API then
I'd suggest doing that in OnLocationUpdate. That's where location data is sent
to the renderers. In fact, you'd want to track usage for each RenderFrame that
we send the data to, otherwise the tracking is incomplete.

[Daniel Nishi, 2014/07/01 18:37:48]

I've moved the call into OnLocationUpdate in the for loop to grab all
RenderFrameHosts.

Upon further inspection, I noticed that the |requesting_frame| coming into
OnStartUpdating actually is just a GURL() without anything in it, anyway.

+      web_contents(),
+      requesting_frame,
+      web_contents()->GetLastCommittedURL().GetOrigin(),
+      kGeolocationPermission);
+
   updating_frames_[render_frame_host] = enable_high_accuracy;
   RefreshGeolocationOptions();
 }
 
 void GeolocationDispatcherHost::OnStopUpdating(
     RenderFrameHost* render_frame_host) {
   updating_frames_.erase(render_frame_host);
   RefreshGeolocationOptions();
 }
 
@@ skipping 49 matching lines @@
 
       pending_permissions_.erase(pending_permissions_.begin() + i);
       return;
     }
   }
 
   NOTREACHED();
 }
 
 }  // namespace content