Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 356463004: ARM: Fix inline assembly (r21949) for Clang. (Closed)

Created:
6 years, 6 months ago by jbramley
Modified:
6 years, 6 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev, aogilvie_wizcorp.jp
Visibility:
Public.

Description

ARM: Fix inline assembly (r21949) for Clang. Add a 'c' predicate to the immediate syscall number. This tells the compiler to omit the leading '#' that immediates usually have in ARM. The GNU assembler tolerates "ldr r7, =#1234" but Clang does not. BUG=V8:3403 LOG=N R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21963

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/arm/cpu-arm.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jbramley
I don't have a cross-compilation environment working for V8 with Clang, but this works in ...
6 years, 6 months ago (2014-06-24 11:05:56 UTC) #1
Benedikt Meurer
LGTM
6 years, 6 months ago (2014-06-24 11:23:47 UTC) #2
jbramley
6 years, 6 months ago (2014-06-24 11:26:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21963 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698