Disallow fullscreen from within <frame>, even with allowfullscreen

Disallow fullscreen from within <frame>, even with allowfullscreen

This was fixed once before in WebKit:
http://trac.webkit.org/changeset/84706

Unfortunately, webkitfullscreenallowed was the wrong attribute name
and it was added to the wrong <frame> element, so the test didn't
catch when this regressed some time between then and now.

The updated test has been verified to fail without this fix.

BUG=390041
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177204

[philipj_slow, 2014-06-29 22:42:51]

PTAL.

[falken, 2014-06-30 02:11:01]

On 2014/06/29 22:42:51, philipj wrote:
> PTAL.

lgtm.

[philipj_slow, 2014-06-30 08:28:14]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-06-30 08:29:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/philipj@opera.com/356303004/1

[commit-bot: I haz the power, 2014-06-30 09:07:12]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/14534)

[commit-bot: I haz the power, 2014-06-30 09:37:51]

Change committed as 177204

[master_bdyne.net, 2016-04-29 09:27:59]

Hi there.

I think still can't use iframe allowfullscreen with <frame>.
Is there any other working progress or any other solution?

2014년 6월 30일 월요일 오후 6시 37분 52초 UTC+9, commi...@chromium.org 님의 말:
>
> Change committed as 177204 
>
> https://codereview.chromium.org/356303004/ 
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[philipj_slow, 2016-04-29 09:51:05]

You'll have to use an iframe instead, I'm afraid. If you've tested other
browsers and find that Chromium is the only browser that doesn't allow
fullscreen within <frame>, then maybe the spec should change instead, but I
think (didn't verify) that most browsers are now aligned.

On Fri, Apr 29, 2016 at 11:27 AM, <master@bdyne.net> wrote:

> Hi there.
>
> I think still can't use iframe allowfullscreen with <frame>.
> Is there any other working progress or any other solution?
>
> 2014년 6월 30일 월요일 오후 6시 37분 52초 UTC+9, commi...@chromium.org 님의 말:
>>
>> Change committed as 177204
>>
>> https://codereview.chromium.org/356303004/
>>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.