Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: Source/core/dom/FullscreenElementStack.cpp

Issue 356303004: Disallow fullscreen from within <frame>, even with allowfullscreen (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fullscreen/resources/not-allowed.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/FullscreenElementStack.cpp
diff --git a/Source/core/dom/FullscreenElementStack.cpp b/Source/core/dom/FullscreenElementStack.cpp
index 239fe6a6a818725700a660821d6efb5922a8b9b2..f4380de31883e5d89a49795557a0b42f7d5fb779 100644
--- a/Source/core/dom/FullscreenElementStack.cpp
+++ b/Source/core/dom/FullscreenElementStack.cpp
@@ -50,6 +50,8 @@ static bool fullscreenIsAllowedForAllOwners(const Document& document)
if (!owner)
return true;
do {
+ if (!isHTMLIFrameElement(owner))
+ return false;
if (!owner->hasAttribute(allowfullscreenAttr)) {
if (owner->hasAttribute(webkitallowfullscreenAttr))
UseCounter::count(document, UseCounter::PrefixedAllowFullscreenAttribute);
« no previous file with comments | « LayoutTests/fullscreen/resources/not-allowed.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698