First pass on adding a chrome/browser GN target.

First pass on adding a chrome/browser GN target.

This adds a lot of global enable flags for various features used by the browser.

It is not turned on because it does not compile yet. It needs some include directories and generated sources from dependencies that aren't done yet.

It is basically a line-by-line translation of the current chrome_browser.gypi. As such, it looks pretty ugly but I think keeping these in sync will be easiest.

I put in the obvious names of the GN deps. There are surely a bunch that exist in the GN build that aren't here yet but I'm going to save this for later passes.

R=thestig@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280693

[tfarina, 2014-06-29 19:51:10]

+Lei for final approval.

I did not look in details at chrome/browser/BUILD.gn, as you said in the CL
description it looks pretty ugly.

Lei might confirm the changes in chrome/chrome_browser.gypi are OK.

https://codereview.chromium.org/356303002/diff/40001/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/356303002/diff/40001/build/config/BUILD.gn#ne...
build/config/BUILD.gn:136: if (enable_configuration_policy) {
these all looks correct to me.

https://codereview.chromium.org/356303002/diff/40001/build/config/features.gni
File build/config/features.gni (right):

https://codereview.chromium.org/356303002/diff/40001/build/config/features.gn...
build/config/features.gni:96: enable_configuration_policy = true
I was not able to verify all this conditions in build/common.gypi, but I will
trust in your judgment here and assume they are correct.

https://codereview.chromium.org/356303002/diff/40001/build/secondary/tools/gr...
File build/secondary/tools/grit/grit_rule.gni (right):

https://codereview.chromium.org/356303002/diff/40001/build/secondary/tools/gr...
build/secondary/tools/grit/grit_rule.gni:57: if (enable_task_manager) {
ok

https://codereview.chromium.org/356303002/diff/40001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (left):

https://codereview.chromium.org/356303002/diff/40001/chrome/chrome_browser.gy...
chrome/chrome_browser.gypi:705:
'browser/local_discovery/privet_local_printer_lister.h',
why did you remove these?

https://codereview.chromium.org/356303002/diff/40001/chrome/chrome_browser.gy...
chrome/chrome_browser.gypi:1676:
'<(grit_out_dir)/grit/component_extension_resources_map.cc',
I do not know why you make this change.

[brettw, 2014-06-30 18:10:01]

https://codereview.chromium.org/356303002/diff/40001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (left):

https://codereview.chromium.org/356303002/diff/40001/chrome/chrome_browser.gy...
chrome/chrome_browser.gypi:705:
'browser/local_discovery/privet_local_printer_lister.h',
On 2014/06/29 19:51:10, tfarina wrote:
> why did you remove these?

It's in another list already.

https://codereview.chromium.org/356303002/diff/40001/chrome/chrome_browser.gy...
chrome/chrome_browser.gypi:1676:
'<(grit_out_dir)/grit/component_extension_resources_map.cc',
On 2014/06/29 19:51:10, tfarina wrote:
> I do not know why you make this change.

I don't want these GYP variables to appear in the GN file list, since the
importer doesn't handle them. We'll have to do this separately.

[Lei Zhang, 2014-06-30 21:41:23]

lgtm

https://codereview.chromium.org/356303002/diff/40001/build/config/features.gni
File build/config/features.gni (right):

https://codereview.chromium.org/356303002/diff/40001/build/config/features.gn...
build/config/features.gni:96: enable_configuration_policy = true
On 2014/06/29 19:51:10, tfarina wrote:
> I was not able to verify all this conditions in build/common.gypi, but I will
> trust in your judgment here and assume they are correct.

It defaults to 1 without any conditionals in build/common.gypi.

https://codereview.chromium.org/356303002/diff/40001/build/config/features.gn...
build/config/features.gni:118: # TODO(brettw) why do we have this if it's always
true?
Add a TODO(scottmg) to remove this. There's two code paths for printing on
Windows currently and we haven't deleted the old impl just yet.

[brettw, 2014-06-30 23:24:36]

Committed patchset #4 manually as r280693 (presubmit successful).