Issue 356243002: Delete gesture_action.py and remove support for JSON attributes

Issue 356243002: Delete gesture_action.py and remove support for JSON attributes (Closed)

Created:
6 years, 5 months ago by chrishenry

Modified:
6 years, 5 months ago

Reviewers:
dtu

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Delete gesture_action.py and remove support for JSON attributes completely from page_action. Make ActionRunner.RunAction private. BUG=361809 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282570

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase and address review comments. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -136 lines)			Patch
M	tools/telemetry/telemetry/page/actions/action_runner.py	View	1	17 chunks	+17 lines, -19 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/action_runner_unittest.py	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
D	tools/telemetry/telemetry/page/actions/gesture_action.py	View		1 chunk	+0 lines, -50 lines	0 comments	Download
D	tools/telemetry/telemetry/page/actions/gesture_action_unittest.py	View		1 chunk	+0 lines, -23 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/javascript_click.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/actions/page_action.py	View	1	4 chunks	+22 lines, -6 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/pinch.py	View		3 chunks	+4 lines, -6 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/pinch_unittest.py	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/scroll.py	View		4 chunks	+6 lines, -9 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/scroll_bounce.py	View		4 chunks	+4 lines, -6 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/swipe.py	View		4 chunks	+4 lines, -6 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/tap.py	View		2 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dtu

Great! lgtm with nit https://codereview.chromium.org/356243002/diff/1/tools/telemetry/telemetry/page/actions/page_action.py File tools/telemetry/telemetry/page/actions/page_action.py (right): https://codereview.chromium.org/356243002/diff/1/tools/telemetry/telemetry/page/actions/page_action.py#newcode20 tools/telemetry/telemetry/page/actions/page_action.py:20: pass Not needed, remove

6 years, 5 months ago (2014-06-27 19:47:22 UTC) #2

chrishenry

https://codereview.chromium.org/356243002/diff/1/tools/telemetry/telemetry/page/actions/page_action.py File tools/telemetry/telemetry/page/actions/page_action.py (right): https://codereview.chromium.org/356243002/diff/1/tools/telemetry/telemetry/page/actions/page_action.py#newcode20 tools/telemetry/telemetry/page/actions/page_action.py:20: pass On 2014/06/27 19:47:22, dtu wrote: > Not needed, ...

6 years, 5 months ago (2014-07-10 23:49:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/356243002/40001

6 years, 5 months ago (2014-07-11 00:37:26 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...

6 years, 5 months ago (2014-07-11 03:46:00 UTC) #6

Message was sent while issue was closed.

Change committed as 282570

Expand Messages | Collapse Messages