Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: tools/telemetry/telemetry/page/actions/tap.py

Issue 356243002: Delete gesture_action.py and remove support for JSON attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and address review comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/actions/swipe.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/actions/tap.py
diff --git a/tools/telemetry/telemetry/page/actions/tap.py b/tools/telemetry/telemetry/page/actions/tap.py
index a7cc473847aa87f919852449e97f469d369db026..efcd32e2c37aba9243af2379af15e922c08b2258 100644
--- a/tools/telemetry/telemetry/page/actions/tap.py
+++ b/tools/telemetry/telemetry/page/actions/tap.py
@@ -4,15 +4,13 @@
import os
-from telemetry.page.actions.gesture_action import GestureAction
from telemetry.page.actions import page_action
-class TapAction(GestureAction):
+class TapAction(page_action.PageAction):
def __init__(self, selector=None, text=None, element_function=None,
left_position_percentage=0.5, top_position_percentage=0.5,
duration_ms=50):
super(TapAction, self).__init__()
- self.automatically_record_interaction = False
self.selector = selector
self.text = text
self.element_function = element_function
@@ -41,10 +39,10 @@ class TapAction(GestureAction):
return (self.element_function is not None or self.selector is not None or
self.text is not None)
- def RunGesture(self, tab):
+ def RunAction(self, tab):
if not self.HasElementSelector():
self.element_function = 'document.body'
- gesture_source_type = GestureAction.GetGestureSourceTypeFromOptions(tab)
+ gesture_source_type = page_action.GetGestureSourceTypeFromOptions(tab)
tap_cmd = ('''
window.__tapAction.start({
« no previous file with comments | « tools/telemetry/telemetry/page/actions/swipe.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698