Issue 355953003: Fixed srcset descriptor parsing bug and added tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 355953003: Fixed srcset descriptor parsing bug and added tests (Closed)

Created:
6 years, 5 months ago by Yoav Weiss

Modified:
6 years, 5 months ago

Reviewers:
esprehn, eseidel

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fixed srcset descriptor parsing bug and added tests Srcset's 'w' descriptor parsing accepted descriptors of the form "400pw". This CL fixes that by making their parsing stricter. It also adds a bunch of tests to prevent it from regressing, and to make sure float based descriptors are properly parsed as well. BUG=389575 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177120

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	Source/core/html/parser/HTMLSrcsetParser.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/html/parser/HTMLSrcsetParserTest.cpp	View		2 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/355953003/1

6 years, 5 months ago (2014-06-27 16:33:29 UTC) #3

Message was sent while issue was closed.

Change committed as 177120

Expand Messages | Collapse Messages