Source/core/html/parser/HTMLSrcsetParser.cpp - Issue 355953003: Fixed srcset descriptor parsing bug and added tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/parser/HTMLSrcsetParser.cpp

Issue 355953003: Fixed srcset descriptor parsing bug and added tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/parser/HTMLSrcsetParser.cpp

diff --git a/Source/core/html/parser/HTMLSrcsetParser.cpp b/Source/core/html/parser/HTMLSrcsetParser.cpp

index f1af160e354f195de898ec712956edc044985028..bf4bec424650dc604e3b7c8667d60ae9beed240e 100644

--- a/Source/core/html/parser/HTMLSrcsetParser.cpp

+++ b/Source/core/html/parser/HTMLSrcsetParser.cpp

@@ -67,7 +67,7 @@ struct DescriptorToken {

template<typename CharType>

int toInt(const CharType* attribute, bool& isValid)

{

- return charactersToInt(attribute + start, length - 1, &isValid);

+ return charactersToIntStrict(attribute + start, length - 1, &isValid);

}

template<typename CharType>

« no previous file with comments | « no previous file | Source/core/html/parser/HTMLSrcsetParserTest.cpp » ('j') | no next file with comments »