Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 355823003: Better fix for --trace-ic source positions: Use HOptimizedGraphBuilderWithPositions (Closed)

Created:
6 years, 6 months ago by Jakob Kummerow
Modified:
6 years, 6 months ago
Reviewers:
Yang
CC:
v8-dev, danno
Project:
v8
Visibility:
Public.

Description

Better fix for --trace-ic source positions: Use HOptimizedGraphBuilderWithPositions This reverts the changes made in r22008. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
6 years, 6 months ago (2014-06-25 12:35:23 UTC) #1
Yang
On 2014/06/25 12:35:23, Jakob wrote: lgtm.
6 years, 6 months ago (2014-06-25 12:36:00 UTC) #2
Jakob Kummerow
6 years, 6 months ago (2014-06-25 12:37:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22012 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698