src/compiler.cc - Issue 355823003: Better fix for --trace-ic source positions: Use HOptimizedGraphBuilderWithPositions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 355823003: Better fix for --trace-ic source positions: Use HOptimizedGraphBuilderWithPositions (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index d9fb4a9b0d0335045a42477c6378879061f555c4..f471224b42c5430f7f2c551efe569f0e10609990 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -394,7 +394,7 @@ OptimizedCompileJob::Status OptimizedCompileJob::CreateGraph() {

// Type-check the function.

AstTyper::Run(info());

- graph_builder_ = FLAG_hydrogen_track_positions

+ graph_builder_ = (FLAG_hydrogen_track_positions || FLAG_trace_ic)

? new(info()->zone()) HOptimizedGraphBuilderWithPositions(info())

: new(info()->zone()) HOptimizedGraphBuilder(info());

« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »