Source/core/rendering/svg/RenderSVGEllipse.h - Issue 355813004: [SVG2] Elements that don't render shouldn't contribute to ancestor bboxes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGEllipse.h

Issue 355813004: [SVG2] Elements that don't render shouldn't contribute to ancestor bboxes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review fixes + testharness test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/svg/custom/getBBox-perpendicular-polyline-expected.txt ('k') | Source/core/rendering/svg/RenderSVGShape.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/svg/RenderSVGEllipse.h

diff --git a/Source/core/rendering/svg/RenderSVGEllipse.h b/Source/core/rendering/svg/RenderSVGEllipse.h

index b73b5526853a2d1c1c684f2e2f909e1d539d94f8..fcb797a7be2ab284c659cd474104387c3d540bab 100644

--- a/Source/core/rendering/svg/RenderSVGEllipse.h

+++ b/Source/core/rendering/svg/RenderSVGEllipse.h

@@ -45,6 +45,7 @@ private:

virtual void strokeShape(GraphicsContext*) const OVERRIDE;

virtual bool shapeDependentStrokeContains(const FloatPoint&) OVERRIDE;

virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) const OVERRIDE;

fs 2014/06/25 15:06:52 Nit: Maybe drop this stray change.

void calculateRadiiAndCenter();

private:

« no previous file with comments | « LayoutTests/svg/custom/getBBox-perpendicular-polyline-expected.txt ('k') | Source/core/rendering/svg/RenderSVGShape.h » ('j') | no next file with comments »