Source/core/rendering/svg/RenderSVGEllipse.h - Issue 355813004: [SVG2] Elements that don't render shouldn't contribute to ancestor bboxes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/rendering/svg/RenderSVGEllipse.h

Issue 355813004: [SVG2] Elements that don't render shouldn't contribute to ancestor bboxes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review fixes + testharness test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google, Inc.	2 * Copyright (C) 2012 Google, Inc.

3 * All rights reserved.	3 * All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 27 matching lines...) Expand all Loading...
38	38

39 private:	39 private:

40 virtual const char* renderName() const OVERRIDE { return "RenderSVGEllipse"; }	40 virtual const char* renderName() const OVERRIDE { return "RenderSVGEllipse"; }

41	41

42 virtual void updateShapeFromElement() OVERRIDE;	42 virtual void updateShapeFromElement() OVERRIDE;

43 virtual bool isShapeEmpty() const OVERRIDE { return m_usePathFallback ? Rend erSVGShape::isShapeEmpty() : m_fillBoundingBox.isEmpty(); }	43 virtual bool isShapeEmpty() const OVERRIDE { return m_usePathFallback ? Rend erSVGShape::isShapeEmpty() : m_fillBoundingBox.isEmpty(); }

44 virtual void fillShape(GraphicsContext*) const OVERRIDE;	44 virtual void fillShape(GraphicsContext*) const OVERRIDE;

45 virtual void strokeShape(GraphicsContext*) const OVERRIDE;	45 virtual void strokeShape(GraphicsContext*) const OVERRIDE;

46 virtual bool shapeDependentStrokeContains(const FloatPoint&) OVERRIDE;	46 virtual bool shapeDependentStrokeContains(const FloatPoint&) OVERRIDE;

47 virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) c onst OVERRIDE;	47 virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) c onst OVERRIDE;

	48
	fs 2014/06/25 15:06:52 Nit: Maybe drop this stray change. Nit: Maybe drop this stray change.
48 void calculateRadiiAndCenter();	49 void calculateRadiiAndCenter();

49	50

50 private:	51 private:

51 FloatPoint m_center;	52 FloatPoint m_center;

52 FloatSize m_radii;	53 FloatSize m_radii;

53 bool m_usePathFallback;	54 bool m_usePathFallback;

54 };	55 };

55	56

56 }	57 }

57	58

58 #endif	59 #endif

OLD	NEW

« no previous file with comments | « LayoutTests/svg/custom/getBBox-perpendicular-polyline-expected.txt ('k') | Source/core/rendering/svg/RenderSVGShape.h » ('j') | no next file with comments »