Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 355763002: Fix Android x86 builds of libvpx (Closed)

Created:
5 years ago by Johann
Modified:
5 years ago
Reviewers:
fgalligan1, Tom Finegan
CC:
chromium-reviews, wwcv, jzern
Visibility:
Public.

Description

Fix Android x86 builds of libvpx Android previously didn't define rand(). We had a workaround which used the inline _rand, but they added rand() to android and removed _rand. So now we call lrand48() which is available in all versions. BUG=388490 TBR=tomfinegan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279590

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M libvpx.gyp View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johann
Committed patchset #1 manually as r279590 (presubmit successful).
5 years ago (2014-06-25 04:50:01 UTC) #1
Tom Finegan
On 2014/06/25 04:50:01, Johann wrote: > Committed patchset #1 manually as r279590 (presubmit successful). lgtm
5 years ago (2014-06-25 04:57:52 UTC) #2
fgalligan1
5 years ago (2014-06-25 05:22:03 UTC) #3
Message was sent while issue was closed.
On 2014/06/25 04:57:52, Tom Finegan wrote:
> On 2014/06/25 04:50:01, Johann wrote:
> > Committed patchset #1 manually as r279590 (presubmit successful).
> 
> lgtm

lgtm

Powered by Google App Engine
This is Rietveld 408576698