Issue 355763002: Fix Android x86 builds of libvpx

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 355763002: Fix Android x86 builds of libvpx (Closed)

Created:
6 years, 6 months ago by Johann

Modified:
6 years, 6 months ago

Reviewers:
fgalligan1, Tom Finegan

CC:
chromium-reviews, wwcv, jzern

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/libvpx/

Visibility:
Public.

More Reviews

Description

Fix Android x86 builds of libvpx Android previously didn't define rand(). We had a workaround which used the inline _rand, but they added rand() to android and removed _rand. So now we call lrand48() which is available in all versions. BUG=388490 TBR=tomfinegan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279590

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	libvpx.gyp	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johann

Committed patchset #1 manually as r279590 (presubmit successful).

6 years, 6 months ago (2014-06-25 04:50:01 UTC) #1

Tom Finegan

On 2014/06/25 04:50:01, Johann wrote: > Committed patchset #1 manually as r279590 (presubmit successful). lgtm

6 years, 6 months ago (2014-06-25 04:57:52 UTC) #2

fgalligan1

6 years, 6 months ago (2014-06-25 05:22:03 UTC) #3

Message was sent while issue was closed.

On 2014/06/25 04:57:52, Tom Finegan wrote:
> On 2014/06/25 04:50:01, Johann wrote:
> > Committed patchset #1 manually as r279590 (presubmit successful).
> 
> lgtm

lgtm

Expand Messages | Collapse Messages