Land Recent QUIC Changes.

Land Recent QUIC Changes.

Deleted unneeded enums from HandshakeFailureReason.

Updated the comments for enums.

Replaced CLIENT_NONCE_UNKNOWN_FAILURE with CLIENT_NONCE_INVALID_FAILURE.
In CL: 69888738, replaced usage of CLIENT_NONCE_UNKNOWN_FAILURE with the
correct reason.

Fixed comments from wtc in CLs: 69773346, 69963869

Minor cleanup of code.

Merge internal change: 70135161
https://codereview.chromium.org/359823002/


Clarifying comment in quic_sent_packet_manager.h

Merge internal change: 70122967
https://codereview.chromium.org/335463009/


Simplify the QuicDispatcher::OnCanWrite logic

Before a refactoring, connections used to be able to add themselves to
QuicDispatcher::write_blocked_list_ even when they weren't
write-blocked, making it necessary to give each connection only one
attempt to write. However, this is no longer the case. Thus, the
QuicDispatcher::OnCanWrite can now simply keep going until either no
work is left or a connection gets write-blocked, and it's guaranteed
that no connection will come up twice (since if it gets added back to
write_blocked_list_, it is now blocked and the loop terminates). I've
added a longer explanatory comment and inserted a stronger check to make
sure the condition holds.

Simplify QuicDispatcher::OnCanWrite logic

Most of the changes were already in net/quic/quic_dispatcher.*. Merged
missing changes.

Merge internal change: 70043318
https://codereview.chromium.org/359653003/


Repair the CWND reduction caused by spurious RTO's in QUIC's congestion
control.

Merge internal change: 70033195
https://codereview.chromium.org/352403002/


Minor change - subtract 1 from reject reason before left shifting while
recording in UMA histogram (more over UMA we can not track 2147483648).

Merge internal change: 69982953
https://codereview.chromium.org/337263004/


Renumber HandshakeFailureReason enums so that there are no big gaps.
Changed quic_crypto_client_config.cc to just left shift the reject
reason before uploading the reject reasons to UMA.

Thanks rch for the suggestion.

Deleted RejectReasonToPackedError and the unit tests for that
method.

Minor cleanup of code.

Merge internal change: 69963869
https://codereview.chromium.org/345563009/


Killing off quic V17.  Not flag protected.

Merge internal change: 69929257
https://codereview.chromium.org/350973003/


Adds an internal server and chromium's flag for disabling/enabling FEC
protection, and control of FEC policy using client-specified tags.

Internal server's flag can be used for enabling/disabling FEC
protection. For FEC protection to be used, client has to request
protection through the config in the CHLO. Only one tag is currently
specified (kHDR, which maps to FEC protection for the headers and crypto
streams), but the plan is to introduce at least one more tag soon (kHED,
which will map to FEC protection for the headers and crypto streams and
also the heads of all other streams.). These tags map to overall FEC
configs, and the plan is to try out configs via finch.

Disabled FLAGS_enable_quic_fec flag in chromium. Will enable in a
separate CL after talking with jri.

Merge internal change: 69898759
https://codereview.chromium.org/351133002/


Move HandshakeFailureReason from quic_crypto_server_config.h into
crypto_handshake.h because it is shared with quic_crypto_client_config.h

(per review comments from wtc).

Minor cleanup of the code.

Merge internal change: 69895742
https://codereview.chromium.org/354943002/


Fix QUIC's SendAlgorithmSimulator to fix an off by 1 error in the buffer
size calculation, allowing packets to be sent faster than the simulated
bandwidth.

Merge internal change: 69885161
https://codereview.chromium.org/350733006/


QUIC - Merging internal changes to pack reject reason.

These changes will be redone in the merge CLs:
   69895742, 69982953, 69963869

Merge internal change: 69862576
https://codereview.chromium.org/349513004/

R=rch@chromium.org, wtc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280647

[ramant (doing other things), 2014-06-27 23:37:30]

Hi Wan-Teh,
  This is the merged CL of list of CLs (in the description, there is a link to
each CL that was LGTM'ed).

  All the CL's were already code reviewed/approved either by you (or others on
quic team) in the internal source tree. Would appreciate, if you could take a
look changes in quic/crypto area.

thanks
raman

[Ryan Hamilton, 2014-06-28 00:19:11]

lgtm

[ramant (doing other things), 2014-06-29 03:00:17]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-06-29 03:00:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/355573007/40001

[commit-bot: I haz the power, 2014-06-29 03:09:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[commit-bot: I haz the power, 2014-06-29 03:17:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-29 03:17:18]

Try jobs failed on following builders:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[ramant (doing other things), 2014-06-30 15:34:17]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-06-30 15:34:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/355573007/60001

[commit-bot: I haz the power, 2014-06-30 19:48:26]

Change committed as 280647

[wtc, 2014-07-08 18:03:30]

net/quic/crypto in patch set 3 LGTM.