Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: net/quic/quic_client_session.h

Issue 355293003: Restrict QUIC session pool when channel ID is present. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_client_session.cc » ('j') | net/quic/quic_client_session.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_client_session.h
diff --git a/net/quic/quic_client_session.h b/net/quic/quic_client_session.h
index 7fbe3db5cd1871dbfcff24fb8076bb03e4f5090b..13fc0998b214afc588d0f2caf3aae81b6fa60af4 100644
--- a/net/quic/quic_client_session.h
+++ b/net/quic/quic_client_session.h
@@ -87,10 +87,11 @@ class NET_EXPORT_PRIVATE QuicClientSession : public QuicClientSessionBase {
DISALLOW_COPY_AND_ASSIGN(StreamRequest);
};
- // Constructs a new session which will own |connection| and |helper|, but
- // not |stream_factory|, which must outlive this session.
+ // Constructs a new session connected to |host_port_pair| which will own
wtc 2014/07/01 23:00:14 host_port_pair => server_host_port
Ryan Hamilton 2014/07/01 23:26:19 Reverted this and just used server_id instead.
+ // |connection|, but not |stream_factory|, which must outlive this session.
// TODO(rch): decouple the factory from the session via a Delegate interface.
- QuicClientSession(QuicConnection* connection,
+ QuicClientSession(const HostPortPair& server_host_port,
wtc 2014/07/01 23:00:14 IMPORTANT: the HostPortPair is readily available i
Ryan Hamilton 2014/07/01 23:26:19 Done.
+ QuicConnection* connection,
scoped_ptr<DatagramClientSocket> socket,
scoped_ptr<QuicDefaultPacketWriter> writer,
QuicStreamFactory* stream_factory,
@@ -219,6 +220,7 @@ class NET_EXPORT_PRIVATE QuicClientSession : public QuicClientSessionBase {
void OnConnectTimeout();
+ const HostPortPair server_host_port_;
bool require_confirmation_;
scoped_ptr<QuicCryptoClientStream> crypto_stream_;
QuicStreamFactory* stream_factory_;
« no previous file with comments | « no previous file | net/quic/quic_client_session.cc » ('j') | net/quic/quic_client_session.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698