Chromium Code Reviews| Index: net/quic/quic_client_session.h |
| diff --git a/net/quic/quic_client_session.h b/net/quic/quic_client_session.h |
| index 7fbe3db5cd1871dbfcff24fb8076bb03e4f5090b..f0a55efa6ddc108ed09ba987c98a7d9990bcb62e 100644 |
| --- a/net/quic/quic_client_session.h |
| +++ b/net/quic/quic_client_session.h |
| @@ -90,7 +90,8 @@ class NET_EXPORT_PRIVATE QuicClientSession : public QuicClientSessionBase { |
| // Constructs a new session which will own |connection| and |helper|, but |
|
wtc
2014/06/27 23:55:51
Please update this comment. The |helper| parameter
Ryan Hamilton
2014/07/01 18:37:17
Done.
|
| // not |stream_factory|, which must outlive this session. |
| // TODO(rch): decouple the factory from the session via a Delegate interface. |
| - QuicClientSession(QuicConnection* connection, |
| + QuicClientSession(const HostPortPair& host_port_pair, |
| + QuicConnection* connection, |
| scoped_ptr<DatagramClientSocket> socket, |
| scoped_ptr<QuicDefaultPacketWriter> writer, |
| QuicStreamFactory* stream_factory, |
| @@ -219,6 +220,7 @@ class NET_EXPORT_PRIVATE QuicClientSession : public QuicClientSessionBase { |
| void OnConnectTimeout(); |
| + const HostPortPair host_port_pair_; |
|
wtc
2014/06/27 23:55:51
Nit: it may be better to name this field server_ho
Ryan Hamilton
2014/07/01 18:37:17
Done.
|
| bool require_confirmation_; |
| scoped_ptr<QuicCryptoClientStream> crypto_stream_; |
| QuicStreamFactory* stream_factory_; |