Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 355203002: Revert of [telemetry] Refactor run_tests to remove old cruft. (Closed)

Created:
6 years, 5 months ago by Johnny
Modified:
6 years, 5 months ago
Reviewers:
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

Revert of [telemetry] Refactor run_tests to remove old cruft. (https://codereview.chromium.org/228073002/) Reason for revert: Causing builder failures, eg: http://build.chromium.org/p/chromiumos.chromium/builders/AMD64%20%28chromium%29/builds/333 Error is missing gtest_testrunner module, removed in this CL: ERROR:root:selenium module failed to be imported. autotest-chrome-0.0.1-r3848: ERROR:root:telemetry_UnitTests import error: cannot import name gtest_testrunner. Skipping telemetry_UnitTests autotest-chrome-0.0.1-r3848: Traceback (most recent call last): autotest-chrome-0.0.1-r3848: File "/build/amd64-generic/tmp/portage/chromeos-base/autotest-chrome-0.0.1-r3848/work/autotest-work/client/bin/setup_job.py", line 72, in init_test autotest-chrome-0.0.1-r3848: exec import_stmt + '\n' + init_stmt in locals_dict, globals_dict autotest-chrome-0.0.1-r3848: File "<string>", line 1, in <module> autotest-chrome-0.0.1-r3848: File "/build/amd64-generic/tmp/portage/chromeos-base/autotest-chrome-0.0.1-r3848/work/autotest-work/client/site_tests/telemetry_UnitTests/telemetry_UnitTests.py", line 7, in <module> autotest-chrome-0.0.1-r3848: from telemetry.unittest import gtest_testrunner, run_tests autotest-chrome-0.0.1-r3848: ImportError: cannot import name gtest_testrunner TBR=nduca, tonyg, Ken Russell, dtu NOTRY=true NOTREECHECKS=true BUG=346956 Original issue's description: > [telemetry] Refactor run_tests to remove old cruft. > > - Remove dead code and circuitous code paths. > - Make its API consistent with run_benchmark, taking advantage of command_line.OptparseCommand. > > > BUG=346956 > TEST=tools/telemetry/run_tests && tools/perf/run_tests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280232 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -166 lines) Patch
M content/test/gpu/run_unittests View 1 chunk +10 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/benchmark_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/run_tests View 1 chunk +11 lines, -5 lines 0 comments Download
M tools/telemetry/run_tests View 1 chunk +10 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/command_line.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/base_test_results_unittest.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/results/gtest_test_results.py View 4 chunks +13 lines, -10 lines 0 comments Download
A tools/telemetry/telemetry/unittest/gtest_testrunner.py View 1 chunk +48 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/unittest/gtest_unittest_results.py View 4 chunks +5 lines, -33 lines 0 comments Download
M tools/telemetry/telemetry/unittest/options_for_unittests.py View 2 chunks +7 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/unittest/run_tests.py View 2 chunks +73 lines, -94 lines 0 comments Download
M tools/telemetry/telemetry/unittest/run_tests_unittest.py View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Johnny
Created Revert of [telemetry] Refactor run_tests to remove old cruft.
6 years, 5 months ago (2014-06-27 16:23:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/355203002/1
6 years, 5 months ago (2014-06-27 16:24:36 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 16:24:36 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-06-27 16:24:37 UTC) #4
Johnny
The CQ bit was checked by jgraettinger@chromium.org
6 years, 5 months ago (2014-06-27 16:27:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/355203002/1
6 years, 5 months ago (2014-06-27 16:28:45 UTC) #6
Johnny
The CQ bit was unchecked by jgraettinger@chromium.org
6 years, 5 months ago (2014-06-27 16:30:44 UTC) #7
Johnny
The CQ bit was checked by jgraettinger@chromium.org
6 years, 5 months ago (2014-06-27 16:30:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/355203002/1
6 years, 5 months ago (2014-06-27 16:31:19 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 16:32:43 UTC) #10
Message was sent while issue was closed.
Change committed as 280340

Powered by Google App Engine
This is Rietveld 408576698