Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: tools/telemetry/telemetry/results/gtest_test_results.py

Issue 355203002: Revert of [telemetry] Refactor run_tests to remove old cruft. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/gtest_test_results.py
diff --git a/tools/telemetry/telemetry/results/gtest_test_results.py b/tools/telemetry/telemetry/results/gtest_test_results.py
index 33fa00358bc4dcf7d1d23121167abbba3ea8fdfa..5f30a7b141c4790db1e3ae578c5944b9b9155cc5 100644
--- a/tools/telemetry/telemetry/results/gtest_test_results.py
+++ b/tools/telemetry/telemetry/results/gtest_test_results.py
@@ -3,6 +3,7 @@
# found in the LICENSE file.
import logging
+import sys
import time
from telemetry.results import page_test_results
@@ -24,7 +25,7 @@
print >> self._output_stream, self._GetStringFromExcInfo(err)
print >> self._output_stream, '[ FAILED ]', page.display_name, (
'(%0.f ms)' % self._GetMs())
- self._output_stream.flush()
+ sys.stdout.flush()
def AddError(self, page, err):
super(GTestTestResults, self).AddError(page, err)
@@ -36,25 +37,27 @@
def StartTest(self, page):
super(GTestTestResults, self).StartTest(page)
- print >> self._output_stream, '[ RUN ]', page.display_name
- self._output_stream.flush()
+ print >> self._output_stream, '[ RUN ]', (
+ page.display_name)
+ sys.stdout.flush()
self._timestamp = time.time()
def AddSuccess(self, page):
super(GTestTestResults, self).AddSuccess(page)
- print >> self._output_stream, '[ OK ]', page.display_name, (
+ test_name = page.display_name
+ print >> self._output_stream, '[ OK ]', test_name, (
'(%0.f ms)' % self._GetMs())
- self._output_stream.flush()
+ sys.stdout.flush()
def AddSkip(self, page, reason):
super(GTestTestResults, self).AddSkip(page, reason)
- logging.warning('===== SKIPPING TEST %s: %s =====',
- page.display_name, reason)
+ test_name = page.display_name
+ logging.warning('===== SKIPPING TEST %s: %s =====', test_name, reason)
if self._timestamp == None:
self._timestamp = time.time()
- print >> self._output_stream, '[ OK ]', page.display_name, (
+ print >> self._output_stream, '[ OK ]', test_name, (
'(%0.f ms)' % self._GetMs())
- self._output_stream.flush()
+ sys.stdout.flush()
def PrintSummary(self):
unit = 'test' if len(self.successes) == 1 else 'tests'
@@ -74,4 +77,4 @@
unit = 'TEST' if count == 1 else 'TESTS'
print >> self._output_stream, '%d FAILED %s' % (count, unit)
print >> self._output_stream
- self._output_stream.flush()
+ sys.stdout.flush()

Powered by Google App Engine
This is Rietveld 408576698