components/password_manager/core/browser/password_manager_unittest.cc - Issue 355143006: [Password Manager] Add UMA stats to track interaction with synced accounts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_unittest.cc

Issue 355143006: [Password Manager] Add UMA stats to track interaction with synced accounts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix tests Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_form_manager.cc ('K') | « components/password_manager/core/browser/password_manager_client.h ('k') | components/password_manager/core/browser/password_store.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_manager_unittest.cc b/components/password_manager/core/browser/password_manager_unittest.cc

index 7b95a3c32cb87489efb56d97dfd9a5dc4551fcf2..17939892f9fd8e3863a4584ce8fad9bf85cdd0c8 100644

--- a/components/password_manager/core/browser/password_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_manager_unittest.cc

@@ -79,8 +79,8 @@ class PasswordManagerTest : public testing::Test {

true);

store_ = new MockPasswordStore;

- EXPECT_CALL(*store_, ReportMetrics()).Times(AnyNumber());

- CHECK(store_->Init(syncer::SyncableService::StartSyncFlare()));

+ EXPECT_CALL(*store_, ReportMetrics(_)).Times(AnyNumber());

+ CHECK(store_->Init(syncer::SyncableService::StartSyncFlare(), ""));

EXPECT_CALL(client_, GetPasswordStore()).WillRepeatedly(Return(store_));

EXPECT_CALL(client_, GetPrefs()).WillRepeatedly(Return(&prefs_));